Project

General

Profile

Actions

Bug #47720

closed

Class * contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (TYPO3\CMS\Extbase\Persistence\RepositoryInterface::findByIdentifier)

Added by Kay Strobach about 11 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Miscellaneous
Target version:
Start date:
2013-04-30
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Hello Guys,

updating from 6.0 to 6.1 causes the following error in extbase, perhaps we should think about defining the method "non" abstrakt with a deprecation warning, or any other fix.

I think this can be a real showstopper, as all extension_builder extensions prior 6.0 will throw this error.

Regards
Kay

Actions #1

Updated by Wouter Wolters about 11 years ago

Hi Kay,

How did you produced this error? The interface is only used in typo3/sysext/extbase/Classes/Persistence/Repository.php and implements the function.

Actions #2

Updated by Kay Strobach about 11 years ago

:D

I have an extension called themes, which has a repository interfaces the normal repo like extbase does it:

https://github.com/kaystrobach/TYPO3.themes/blob/master/Classes/Domain/Repository/ThemeRepository.php

class Tx_Themes_Domain_Repository_ThemeRepository implements Tx_Extbase_Persistence_RepositoryInterface, t3lib_Singleton {

I see i use the inteface way to extend the class, so the interface has changed :(, mhmm, ok perhaps we can close the issue, but changing interfaces are a bad decission at all.

Regards
Kay

Actions #3

Updated by Kay Strobach about 11 years ago

Mhmm, for me (after rereading the code) the usage of the interface is still correct, as i have a repository, which can't be persisted anyhow. Each record is taken from an array, so it's not suitable for me to "extend" the persistence repository.

Actions #4

Updated by Kay Strobach about 11 years ago

dupe

Actions #5

Updated by Kay Strobach about 11 years ago

changing the declaration also solves this problem. Anyway it's scary if interfaces change!

class Tx_Themes_Domain_Repository_ThemeRepository extends Tx_Extbase_Persistence_Repository implements t3lib_Singleton {
Actions #6

Updated by Christian Kuhn about 11 years ago

  • Category changed from 1394 to Miscellaneous
Actions #7

Updated by Mathias Schreiber over 9 years ago

  • Status changed from New to Closed
  • Is Regression set to No

assuming "fixed"

Actions

Also available in: Atom PDF