Bug #49460
closed
Task #49162: Rewrite install tool
Install Tool fails to test for required modules early in the process
Added by Jigal van Hemert over 11 years ago.
Updated about 6 years ago.
Description
In previous branches the Install Tool had an early check for the required PHP modules. If this check failed the process was stopped because continuing would result in strange error messages or blank pages.
The check for required modules is now a "normal" check. The Install Tool uses functions from these required modules (already in the bootstrap (autoloader)) without checking if the modules are loaded.
The system environment check already has a check for required modules and tests for them. #49458 is clearly a bug and should be fixed by checking for existing method name and otherwise throwing an error status.
The normal check for the required modules is just too late in the process. There is already a lot of functionality from these modules used before this check. It isn't practical to check for each function from these modules.
Hmm, what exactly do you mean? You mention the autoloader using additional php modules, but I can not really find any php module specific code in there. As far as I can see, the environment check class is the first class within the installation process that actually tests for things and checks modules. Method calls in there can be sanitized with function_exist pretty easily.
Even if you have a stripped php environment without many modules, the first step should already come up successfully. The only requirement I can see here is a hard requirement for php 5.3, or you will already fail in the entry script on the first '\' during compile time.
- Status changed from New to Resolved
As discussed with Jigal I see currently no need to add further php extension related code to the install tool in front of the system environment check. If specific issues pop up in this area, we should open new issues to tackle concrete problems.
- % Done changed from 0 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF