Task #49640

Improve feedit & adminpanel

Added by Georg Ringer over 6 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2013-07-03
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The frontendediting definitly needs some love:

- use sprite icons
- improve html & css code
- reposition the icons


Related issues

Related to TYPO3 Core - Bug #55107: Wrong label for cache indication in AdminPanel Closed 2014-01-17
Related to TYPO3 Core - Feature #61095: feedit - Bring back editNoPopup? Closed 2014-08-20

Associated revisions

Revision 545610af (diff)
Added by Georg Ringer almost 6 years ago

[TASK] Improve feedit

The frontend editing + admin panel needs some polishing.
Following changes are included:

General =======
- Reformat code
- Use Sprite API which means using the correct icons

Admin Panel ==============
- Add missing translations
- Show "Simulate usergroup" only if usergroups are available
- Remove "Total page count" in Info Tab as information is wrong
(counting images + document is not the total page size)

Frontend Editing =================
- Remove "edit_editNoPopup", "forceNoPopup", "editFormsOnPage"
for direct inline editing
- Remove setting "previewBorder" which is not needed and looks just ugly

Releases: 6.2
Resolves: #49640
Change-Id: I35f88bc4e8c138fc21b74c0448b2f3892ab61918
Reviewed-on: https://review.typo3.org/21859
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision 9c39b035 (diff)
Added by Paul Golmann about 5 years ago

[TASK] feedit: Bring back editNoPopup

  • Restore edit_editNoPopup/forceNoPopup TSConfig options removed in #49640
  • Initialize frontend editing when displayFieldEditIcons is set

Releases: master, 6.2
Resolves: #61095
Related: #43447
Related: #49640
Change-Id: I900a62b447a1a67265ce22cd73e150646344e090
Reviewed-on: http://review.typo3.org/32279
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 31222b51 (diff)
Added by Paul Golmann about 5 years ago

[TASK] feedit: Bring back editNoPopup

  • Restore edit_editNoPopup/forceNoPopup TSConfig options removed in #49640
  • Initialize frontend editing when displayFieldEditIcons is set

Releases: master, 6.2
Resolves: #61095
Related: #43447
Related: #49640
Change-Id: I900a62b447a1a67265ce22cd73e150646344e090
Reviewed-on: http://review.typo3.org/35142
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review over 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21859

#2 Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21859

#3 Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21859

#4 Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21859

#5 Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21859

#6 Updated by Ernesto Baschny over 6 years ago

@Georg, I send you some comments and feedback to the latest patch by email, as you requested. Do you have some time to finish up until release?

#7 Updated by Gerrit Code Review about 6 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21859

#8 Updated by Gerrit Code Review almost 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/21859

#9 Updated by Gerrit Code Review almost 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/21859

#10 Updated by Georg Ringer almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF