Feature #61095

feedit - Bring back editNoPopup?

Added by Paul Golmann over 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2014-08-20
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

Hello!

First of all thanks @Gregor Ringer for your work on feedit!

I would like to know if you actually wanted to remove the configuration option `edit_editNoPopup` in the commit referenced below? Was it because of security (CSRF or so) issues? This option only changed the behavior of the frontend editing icon-buttons so that they open the edit form in the same window and not in a popup. The affected method `editPanelLinkWrap_doWrap` would only need a little work to bring back that feature.
In some of my projects I used this option and would like to continue to.

Related Commit: 545610af
Related Diff: lines 264 following https://forge.typo3.org/projects/typo3cms-core/repository/revisions/545610af1285629e8355aa6e1f7bdd06b4941026/diff/typo3/sysext/feedit/Classes/FrontendEditPanel.php
Related Issue; #49640

If you do not want this option back in the core anymore I would suggest updating the documentation (I can do a pull request for that):
http://docs.typo3.org/typo3cms/TSconfigReference/UserTsconfig/admPanel/Index.html?highlight=.edit.editNoPopup
http://docs.typo3.org/typo3cms/TSconfigReference/UserTsconfig/admPanel/Index.html?highlight=.forceNoPopup

Also there is another issue related: #43447
And another (old) issue complaining about the documentation: #23412


Related issues

Related to TYPO3 Core - Bug #23412: admPanel configuration by TSconfig is buggy Closed 2010-08-20
Related to TYPO3 Core - Bug #43447: admPanel.override.edit.editNoPopup = 1 doesn't work Closed 2012-11-29
Related to TYPO3 Core - Task #49640: Improve feedit & adminpanel Closed 2013-07-03

Associated revisions

Revision 9c39b035 (diff)
Added by Paul Golmann about 5 years ago

[TASK] feedit: Bring back editNoPopup

  • Restore edit_editNoPopup/forceNoPopup TSConfig options removed in #49640
  • Initialize frontend editing when displayFieldEditIcons is set

Releases: master, 6.2
Resolves: #61095
Related: #43447
Related: #49640
Change-Id: I900a62b447a1a67265ce22cd73e150646344e090
Reviewed-on: http://review.typo3.org/32279
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 31222b51 (diff)
Added by Paul Golmann about 5 years ago

[TASK] feedit: Bring back editNoPopup

  • Restore edit_editNoPopup/forceNoPopup TSConfig options removed in #49640
  • Initialize frontend editing when displayFieldEditIcons is set

Releases: master, 6.2
Resolves: #61095
Related: #43447
Related: #49640
Change-Id: I900a62b447a1a67265ce22cd73e150646344e090
Reviewed-on: http://review.typo3.org/35142
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Markus Klein over 5 years ago

  • Category changed from Code Cleanup to Frontend

I can't tell you the exact reason for removing it, but feel free to re-establish the feature, by pushing a patch. Thanks.

#2 Updated by Paul Golmann over 5 years ago

I'll make a patch and it will also target the Bug #20845. Hopefully it is "good" as I am not a core connoisseur ;)

#3 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279

#4 Updated by Paul Golmann over 5 years ago

Paul Golmann wrote:

I'll make a patch and it will also target the Bug #20845.

I of course meant #22359 not 20845 !

#5 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279

#6 Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279

#7 Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279

#8 Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279

#9 Updated by Paul Golmann over 5 years ago

Is there anything I can do to advance on this issue? Do I need more/other reviews/reviewers?

Thanks
Paul

#10 Updated by Gerrit Code Review about 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279

#11 Updated by Gerrit Code Review about 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279

#12 Updated by Gerrit Code Review about 5 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35142

#13 Updated by Paul Golmann about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#14 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF