Feature #61095
closed
feedit - Bring back editNoPopup?
100%
Description
Hello!
First of all thanks @Gregor Ringer for your work on feedit!
I would like to know if you actually wanted to remove the configuration option `edit_editNoPopup` in the commit referenced below? Was it because of security (CSRF or so) issues? This option only changed the behavior of the frontend editing icon-buttons so that they open the edit form in the same window and not in a popup. The affected method `editPanelLinkWrap_doWrap` would only need a little work to bring back that feature.
In some of my projects I used this option and would like to continue to.
Related Commit: 545610af
Related Diff: lines 264 following https://forge.typo3.org/projects/typo3cms-core/repository/revisions/545610af1285629e8355aa6e1f7bdd06b4941026/diff/typo3/sysext/feedit/Classes/FrontendEditPanel.php
Related Issue; #49640
If you do not want this option back in the core anymore I would suggest updating the documentation (I can do a pull request for that):
http://docs.typo3.org/typo3cms/TSconfigReference/UserTsconfig/admPanel/Index.html?highlight=.edit.editNoPopup
http://docs.typo3.org/typo3cms/TSconfigReference/UserTsconfig/admPanel/Index.html?highlight=.forceNoPopup
Also there is another issue related: #43447
And another (old) issue complaining about the documentation: #23412
Updated by Markus Klein over 9 years ago
- Category changed from Code Cleanup to Frontend
I can't tell you the exact reason for removing it, but feel free to re-establish the feature, by pushing a patch. Thanks.
Updated by Paul Golmann over 9 years ago
I'll make a patch and it will also target the Bug #20845. Hopefully it is "good" as I am not a core connoisseur ;)
Updated by Gerrit Code Review over 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279
Updated by Paul Golmann over 9 years ago
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279
Updated by Gerrit Code Review over 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279
Updated by Gerrit Code Review over 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279
Updated by Paul Golmann over 9 years ago
Is there anything I can do to advance on this issue? Do I need more/other reviews/reviewers?
Thanks
Paul
Updated by Gerrit Code Review over 9 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279
Updated by Gerrit Code Review over 9 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32279
Updated by Gerrit Code Review over 9 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35142
Updated by Paul Golmann over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9c39b035d9d2ce380b7da37b8e8c413963e534ff.
Updated by