Bug #50573
closedSome typo3/gfx/*.gif icons are missing
100%
Description
The file has been removed as part of #49112 https://review.typo3.org/#/c/21404/
It is still used in
typo3/sysext/backend/Classes/History/RecordHistory.php 457:
$image = '<img' . IconUtility::skinImg('', 'gfx/unmarkstate.gif') . ' align="top" alt="' . $GLOBALS['LANG']->getLL('unmarkState', 1) . '" title="' . $GLOBALS['LANG']->getLL('unmarkState', 1) . '" />';
Please replace the call by a sprite api call.
Updated by Philipp Gampe about 11 years ago
Another one: typo3/sysext/t3skin/icons/gfx/i/default.gif
This one is used in e.g. the new record wizard.
Updated by Philipp Gampe about 11 years ago
- Subject changed from typo3/gfx/unmarkstate.gif is missing to Some typo3/gfx/*.gif icons are missing
Updated by Krzysztof Adamczyk about 11 years ago
I would like to know if there is anyone who can tell me how it should be done corectly? I checked file TYPO3.CMS/typo3/sysext/t3skin/images/sprites/t3skin.png and i didn't see these images('gfx/unmarkstate.gif' and 'gfx/markstate.gif'). I would like to do this in the following way: add the missing pictures to this image t3skin.png and in the next step create styles for these two images. Finally i want to use method : IconUtility::getSpriteIcon
Updated by Francois Suter about 11 years ago
The icon itself (in PNG format, not GIF) must be added in EXT:t3skin/icons/gfx (it could be another folder than "gfx", but it seems to fit). Then you need to regenerated the sprite by using the sprite generation function of the "extdeveval" extension. For this to be successful make sure that "t3skin" and "core" extensions are writable by your web server, so that extdeveval can write the changes. Three files will be touched:
EXT:core/ext_tables.php
EXT:/t3skin/images/sprites/t3skin.png
EXT:t3skin/stylesheets/sprites/t3skin.css
You will need to include them in your patch.
Updated by Krzysztof Adamczyk about 11 years ago
Thanks for the advice. I'll try to do it tomorrow evening
Updated by Gerrit Code Review about 11 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23546
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23546
Updated by Gerrit Code Review about 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23546
Updated by Gerrit Code Review about 11 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23546
Updated by Krzysztof Adamczyk about 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 3da7139fc8119932749baca916ec0e60f1fc1bf6.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed