Bug #51099
closed
Epic #65814: Make Indexed search extbase plugin shine
Streamline settings/conditions
100%
Description
Currently indexed_search is a pure mess of old- and new school features, and the experimental template is showing less than could be expected. The reason for that is evident:
old school: plugin.tx_indexedsearch.show.rules
Fluid: plugin.tx_indexedsearch.settings.displayRules
and a Rules partial starting with:
<f:if condition="{settings.showRules}">
Updated by Philipp Gampe over 11 years ago
- Status changed from New to Needs Feedback
What do you expect us to do? Improve the template or provide more meaningful settings?
You may also propose a patch: http://wiki.typo3.org/CWT
Updated by Alexander Opitz almost 11 years ago
- Status changed from Needs Feedback to Closed
- Is Regression set to No
No feedback within the last 90 days => closing this ticket.
If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.
Updated by Tymoteusz Motylewski over 9 years ago
- Status changed from Closed to Accepted
- Parent task set to #65814
Updated by Tymoteusz Motylewski almost 9 years ago
either condition in the template has to be changed to {settings.displayRules}
or the TS has to be changed to "showRules = 1"
Updated by Ludwig Rafelsberger almost 9 years ago
- Assignee set to Ludwig Rafelsberger
- TYPO3 Version changed from 6.1 to 7
Did some research on since when this inconsistency exists:
TYPO3 4.5¶
TypoScript:
plugin.tx_indexedsearch.show.rules = 1code correctly uses $this->conf['show.']['rules']
since TYPO3 6.2¶
TypoScript:
ext_typoscript_setup.txt:
plugin.tx_indexedsearch.show.rules = 1Configuration/TypoScript/setup.txt:
plugin.tx_indexedsearch.settings.displayRules = 1Pi1 (classic search plugin):
code correctly uses $this->conf['show.']['rules']
Pi2 (experimental extbase variant):
Fluid uses wrong variable <f:if condition="{settings.showRules}>
looks like we need to treat a fix as breaking change.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46002
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46002
Updated by Gerrit Code Review almost 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46002
Updated by Gerrit Code Review almost 9 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46009
Updated by Ludwig Rafelsberger almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 01ffb0c45ae4894f74d25a39e96bdd7b0dc683da.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46010
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46010
Updated by Ludwig Rafelsberger almost 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset 5b8609ff6f6cd0fb5b150f468a484f02e3da51c3.
Updated by