Bug #52045: Warning in extensionmanager if constraints are not an array - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #52045

closed

Warning in extensionmanager if constraints are not an array

Added by Kay Strobach about 11 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Extension Manager

Target version:

next-patchlevel

Start date:

2013-09-16

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

Warning: array_keys() expects parameter 1 to be array, string given in /mnt/hgfs/!%serverData/www/t3-sources/typo3_src-4.5.27/typo3/sysext/em/classes/tools/class.tx_em_tools.php on line 397 Warning: implode(): Invalid arguments passed in /mnt/hgfs/!%serverData/www/t3-sources/typo3_src-4.5.27/typo3/sysext/em/classes/tools/class.tx_em_tools.php on line 397

-> Solution:

    /**
     * Checks whether the passed dependency is TER2-style (array) and returns a single string for displaying the dependencies.
     *
     * It leaves out all version numbers and the "php" and "typo3" dependencies, as they are implicit and of no interest without the version number.
     *
     * @param    mixed        $dep Either a string or an array listing dependencies.
     * @param    string        $type The dependency type to list if $dep is an array
     * @return    string        A simple dependency list for display
     */
    public static function depToString($dep, $type = 'depends') {
        if (is_array($dep)) {
            if (isset($dep[$type]['php'])) {
                unset($dep[$type]['php']);
            }
            if (isset($dep[$type]['typo3'])) {
                unset($dep[$type]['typo3']);
            }
            if(is_array($dep[$type])) {
                $s = (count($dep[$type])) ? implode(',', array_keys($dep[$type])) : '';
                return $s;
            }
        }
        return '';
    }

~~> if is_array added~~
> please make a patch and send it for review to 4.5

Actions

Copy link

Updated by Markus Klein about 11 years ago

Target version changed from 4.5.30 to next-patchlevel

Actions

Copy link

Updated by Markus Klein about 11 years ago

Which extension is causing this?

Actions

Copy link

Updated by Kay Strobach about 11 years ago

do not know, just took a quick look, the installation, where the error occured has 120 extensions installed and i just started over and needed to fix the extensionmanager, which was not working, because of not parseable JS due to the php error.

It can be any extension with a missing or false type depends, conflicts or suggests section.

Anyway the check with count is simply false, it needs to check wether it's an array or not :D

The patch is really a no-brainer just wrap it in the if(is_array ...) as in the changed function in the patch description

+            if(is_array($dep[$type])) {
                $s = (count($dep[$type])) ? implode(',', array_keys($dep[$type])) : '';
                return $s;
+            }

Actions

Copy link