TYPO3 Core

The namespaced eval function generates an invalid javascript function name "function SpoonerWeb\BeSecurePw\Evaluation\PasswordEvaluator(newValue)". In chrome this breaks all the TBE_EDITOR definitions and with that all the functionality in jsfunc.tbe_editor.js.

This diff was a quick try to solve the bug. Unfortunately it is not well tested and i have no idea what regressions it could introduce. Therefore it is not ready for a gerrit PR. I posted it anyway because it could lead the guys with a deeper understanding of the TYPO3 BE form internals, where to get their hands dirty.
https://gist.github.com/pAlpha627/7092156

Indeed it would be nice, to have a possibility to use namespaced "eval" functions. At least there should be some syntax checks for the generated Javascript in TYPO3\CMS\Backend\Form\FormEngine, in oder to avoid breaking the whole functionality.

BTW: As of now the master branch of be_secure_pw contained only "PasswordEvaluator" and not "SpoonerWeb\\BeSecurePw\\Evaluation\\PasswordEvaluator" as mentioned in the Bug report. In order to reproduce the bug you have to change the $TCA['be_users']['columns']['password']['config']['eval'] in be_secure_pw/ext_tables.php.

Thanks for the patch. I will have a look on it.
Yes, I thought I pushed the last commit, but I've seen that I forgot to do it. :)

Hi Stefan,

this patch works for me and is not breaking any functionality of other evaluators.
I would suggest to push it to Gerrit. The reviewing people will have corrections for the code, if there are any. :)

Will you push it or should I?

Thomas

Will you push it or should I?

Hi Thomas fine for me if you push it

Stefan

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/25041

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/25041

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/25041

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25041

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25041

• Download extension "be_secure_pw" (master branch) from https://github.com/spoonerWeb/be_secure_pw
• Install it
• Try to edit a be_user record

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25317

Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25318