Project

General

Profile

Actions
Copy link

Bug #53115

closed

T3editor: Make errors/exceptions show correctly

Added by Stefan Neufeind over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Stefan Neufeind
Category:
-
Target version:
-
Start date:
2013-10-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

1) Upon failure an alert is shown, but that mentions some "Document" instead of an errormessage.
That is because the alert for T3editor.lang.errorWhileSaving needs to be adapted to using Xliff correctly.

2) Exceptions are not shown. It would be nice to also have them in the alert.

How to test:
In a typoscript-setupblock, inside the t3edit for example paste the following and hit "save". That should result in an exception since the filename is not okay.

<INCLUDE_TYPOSCRIPT: source="FILE:"> BEGIN:
foobar
<INCLUDE_TYPOSCRIPT: source="FILE:"> END:
Actions
Copy link
 #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24999

Actions
Copy link
 #2

Updated by Francois Suter over 10 years ago

The example code for testing looks weird and does not trigger an exception for me. Can you check, please?

Actions
Copy link
 #3

Updated by Francois Suter over 10 years ago

About testing, this is what you have to paste in your t3editor-enable field:

### <INCLUDE_TYPOSCRIPT: source="FILE:foo/bar.ts"> BEGIN:
123
### <INCLUDE_TYPOSCRIPT: source="FILE:foo/bar.ts"> END:

It's also necessary to reload the editing page first, maybe even clear the cache.

The result of the patch is that a proper error message is displayed in the t3editor, instead of nothing (and some browser popup).

Actions
Copy link
 #4

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24999

Actions
Copy link
 #5

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/25079

Actions
Copy link
 #6

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/25080

Actions
Copy link
 #7

Updated by Stefan Neufeind over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF