Bug #53115
closedT3editor: Make errors/exceptions show correctly
100%
Description
1) Upon failure an alert is shown, but that mentions some "Document" instead of an errormessage.
That is because the alert for T3editor.lang.errorWhileSaving needs to be adapted to using Xliff correctly.
2) Exceptions are not shown. It would be nice to also have them in the alert.
How to test:
In a typoscript-setupblock, inside the t3edit for example paste the following and hit "save". That should result in an exception since the filename is not okay.
<INCLUDE_TYPOSCRIPT: source="FILE:"> BEGIN: foobar <INCLUDE_TYPOSCRIPT: source="FILE:"> END:
Updated by Gerrit Code Review almost 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24999
Updated by Francois Suter almost 11 years ago
The example code for testing looks weird and does not trigger an exception for me. Can you check, please?
Updated by Francois Suter almost 11 years ago
About testing, this is what you have to paste in your t3editor-enable field:
### <INCLUDE_TYPOSCRIPT: source="FILE:foo/bar.ts"> BEGIN: 123 ### <INCLUDE_TYPOSCRIPT: source="FILE:foo/bar.ts"> END:
It's also necessary to reload the editing page first, maybe even clear the cache.
The result of the patch is that a proper error message is displayed in the t3editor, instead of nothing (and some browser popup).
Updated by Gerrit Code Review almost 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24999
Updated by Gerrit Code Review almost 11 years ago
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/25079
Updated by Gerrit Code Review almost 11 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/25080
Updated by Stefan Neufeind almost 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9acac9cf75e5af80fca74d9f9e802ea9edec2160.