Task #53681

Change wording for User Settings "Reset Configuration and Clear Temporary Data"

Added by Ernesto Baschny about 6 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend User Interface
Target version:
Start date:
2013-11-15
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:
Remote Sprint

Description

In #632 it was proposed to change the text of the User Settings, Admin, "Reset Configuration and Clear Temporary Data" and "Clear Temporary Data".

Moreover both button labels point to the same CSH, and for an user its not really clear what the difference is at all.

Suggestions from Jens (http://forge.typo3.org/issues/632#note-15):

  • Reset Configuration and clear temporary data
    • = Reset user settings
  • Clear Temporary data
    • = Reset backend states
    • = Clear backend caching
    • = Remove Temporary Settings
    • = Reset interface states
    • .. other Ideas?

Suggestions from Steffen R:

  • "Reset your backend status (open folders, list setting, tree collapse states, last open tabs..."
  • "Restore this form to default" :)

Related issues

Related to TYPO3 Core - Feature #61224: selective clearance of user temporary data Rejected 2014-08-27
Related to TYPO3 Core - Bug #71315: router - PHP Warning: Creating default object from empty value Closed 2015-11-04

Associated revisions

Revision 9f391b37 (diff)
Added by Benni Mack about 4 years ago

[TASK] Change wording for User Settings reset button

Change the wording on the button in the user settings
to "Reset user settings to default state" and remove the
second "selective reset" button to only change certain options.

Resolves: #53681
Releases: master
Change-Id: I72afcdc3a8e84eb67840eb81b061f6e22867c9a8
Reviewed-on: https://review.typo3.org/44528
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Ernesto Baschny about 6 years ago

On Trello Board for 6.2 issues:

https://trello.com/c/L8ViBbRO

#2 Updated by Jens Hoffmann about 6 years ago

I would go for:

  • Reset Configuration and clear temporary data = Reset user settings
  • Clear Temporary data = Reset backend states

To me, this doesn't need to be technically precise,
but rather good and easy to understand for editors!

Greez Jens

#3 Updated by Gerrit Code Review about 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25721

#4 Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25721

#5 Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25721

#6 Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25721

#7 Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25721

#8 Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25721

#9 Updated by Ernesto Baschny almost 6 years ago

Not only the buttons are misleading, also the code and variable names in the code is not intuitive.

First "Reset" calls "setValuesToDefault" which will call $GLOBALS['BE_USER']->resetUC() which will delete every uc setting for the current user, which includes not only the settings that can be done through the User Setup module, but also other modules states (i.e. page tree state, list setting, last open tabs etc).

Second "Reset" (which was probably added later on) calls "clearSessionVars" and does the same as above, but will skip the settings done in the User Setup module, thus factually clearing all settings store by other modules (usually state information, i.e. set by Ext.state.Manager.set or $GLOBALS['BE_USER']->pushModuleData).

One can see what is stored there in the "Configuration" module (BE_USER->uc).

Maybe one should argue about the usefullness of both "Reset" buttons in this module. Who understands that and who needs that?

In that form the only reset that makes sense would be one that only resets the current form checkboxes to the "default" and does not fiddle with the session of other modules. And this is the only "Reset" button that is not present currently.

Not sure what to do about it.. yet. :)

#10 Updated by Markus Klein almost 6 years ago

Thanks for this detailed investigation Ernesto.

I agree this should be drastically simplified.

Do we actually need a button to reset the user settings to the default value?

Speaking for myself, I sometimes needed to reset the UC data of the BE User during the development of backend modules. It's simply more comfortable instead of using the DB.
But I would highly appreciate it, if I could selectively remove settings instead of clearing all of them.

To discuss

  • For the normal user, which is the target here, I'd say we don't need any button at all.
  • For developers/integrators there should be a place somewhere, which enables us to remove some settings specifically. (for instance all UC settings of an extension)

#11 Updated by Ernesto Baschny almost 6 years ago

I think reseting the current form data (setup information) to the "defaults" would be ok. Imagine editor "fiddling around" with the settings and then wanting to "start over".

So I guess the first "Reset" is enough (as a side effect also clearing the backend states...) and simply remove the second Reset for now.

An option to reset specific parts of the states tables is probably most useful for developers and could be placed in an extension, i.e. something like a more modern "extdeveval". :)

#12 Updated by Markus Klein almost 6 years ago

I'm fine with keeping one button.

The specific clearing stuff shall of course go somewhere else, I didn't write this clear enough sorry.

But I don't like the behaviour that the button will clear the "state" of all BE things. For instance it also clears the checkboxes at the bottom in the list module. I usually don't want to change that too if I click a button in the User Settings.
So for me it would suffice that the button just resets the current form with no other side effects.

#13 Updated by Ernesto Baschny almost 6 years ago

Yeah, but this is what currently both buttons do anyway (clearning all session data), so that would at least not "change the known behaviour". Might be that people have been using this button for this purpose in the past. Without alternative (somewhere else) I would not like to change that for now.

#14 Updated by Ernesto Baschny almost 6 years ago

So maybe two buttons:

- one inside the form itself:
"Reset user settings" => resets only the settings of the user settings form (functionality which currently doesn't exist)

- one in some "different" place (maybe in the "clear cache" icon in the top toolbar? or maybe as a button below the User Settings form?):
"Reset backend states" => resets all "states" stored by all backend modules other than those user settings (currently the "Clear Temporary Data" labeled button in the User Settings).

#15 Updated by Stefan Neufeind over 5 years ago

Interesting, I didn't know about these resets :-)
So when a user is reset, that's when the selected "Default language" of that user shows its effect. Hmm, but the user would need to call that reset himself, since there is no button to reset another user, right?

#16 Updated by Markus Klein almost 5 years ago

  • Target version changed from 6.2.0 to 7 LTS
  • Complexity changed from easy to medium

@Stefan: As admin you can simulate a different user in the user settings. So you can reset the user settings of a different user.

#17 Updated by Markus Klein almost 5 years ago

Addition to Ernesto's description: The clear "clearSessionVars" button is ONLY accessible for admins! (so you've to use the simulation feature)

#18 Updated by Benni Mack almost 5 years ago

  • Status changed from Under Review to Rejected

no activity, no proper solution IMHO, abandoned.

#19 Updated by Markus Klein almost 5 years ago

  • Status changed from Rejected to On Hold
  • Assignee set to Markus Klein
  • TYPO3 Version changed from 6.2 to 7

Reassigning this to myself. Still on my ToDo.

#20 Updated by Markus Klein over 4 years ago

  • Sprint Focus set to Remote Sprint

#21 Updated by Gerrit Code Review about 4 years ago

  • Status changed from On Hold to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44528

#22 Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44528

#23 Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44528

#24 Updated by Benni Mack about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#25 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF