TYPO3 Core

On Trello Board for 6.2 issues:

https://trello.com/c/L8ViBbRO

I would go for:

• Reset Configuration and clear temporary data = Reset user settings
• Clear Temporary data = Reset backend states

To me, this doesn't need to be technically precise,
but rather good and easy to understand for editors!

Greez Jens

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25721

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25721

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25721

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25721

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25721

Not only the buttons are misleading, also the code and variable names in the code is not intuitive.

First "Reset" calls "setValuesToDefault" which will call $GLOBALS['BE_USER']->resetUC() which will delete every uc setting for the current user, which includes not only the settings that can be done through the User Setup module, but also other modules states (i.e. page tree state, list setting, last open tabs etc).

Second "Reset" (which was probably added later on) calls "clearSessionVars" and does the same as above, but will skip the settings done in the User Setup module, thus factually clearing all settings store by other modules (usually state information, i.e. set by Ext.state.Manager.set or $GLOBALS['BE_USER']->pushModuleData).

One can see what is stored there in the "Configuration" module (BE_USER->uc).

Maybe one should argue about the usefullness of both "Reset" buttons in this module. Who understands that and who needs that?

In that form the only reset that makes sense would be one that only resets the current form checkboxes to the "default" and does not fiddle with the session of other modules. And this is the only "Reset" button that is not present currently.

Not sure what to do about it.. yet. :)

Thanks for this detailed investigation Ernesto.

I agree this should be drastically simplified.

Do we actually need a button to reset the user settings to the default value?

Speaking for myself, I sometimes needed to reset the UC data of the BE User during the development of backend modules. It's simply more comfortable instead of using the DB.
But I would highly appreciate it, if I could selectively remove settings instead of clearing all of them.

To discuss

• For the normal user, which is the target here, I'd say we don't need any button at all.
• For developers/integrators there should be a place somewhere, which enables us to remove some settings specifically. (for instance all UC settings of an extension)

I think reseting the current form data (setup information) to the "defaults" would be ok. Imagine editor "fiddling around" with the settings and then wanting to "start over".

So I guess the first "Reset" is enough (as a side effect also clearing the backend states...) and simply remove the second Reset for now.

An option to reset specific parts of the states tables is probably most useful for developers and could be placed in an extension, i.e. something like a more modern "extdeveval". :)

I'm fine with keeping one button.

The specific clearing stuff shall of course go somewhere else, I didn't write this clear enough sorry.

But I don't like the behaviour that the button will clear the "state" of all BE things. For instance it also clears the checkboxes at the bottom in the list module. I usually don't want to change that too if I click a button in the User Settings.
So for me it would suffice that the button just resets the current form with no other side effects.

Yeah, but this is what currently both buttons do anyway (clearning all session data), so that would at least not "change the known behaviour". Might be that people have been using this button for this purpose in the past. Without alternative (somewhere else) I would not like to change that for now.

So maybe two buttons:

- one inside the form itself:
"Reset user settings" => resets only the settings of the user settings form (functionality which currently doesn't exist)

- one in some "different" place (maybe in the "clear cache" icon in the top toolbar? or maybe as a button below the User Settings form?):
"Reset backend states" => resets all "states" stored by all backend modules other than those user settings (currently the "Clear Temporary Data" labeled button in the User Settings).

Interesting, I didn't know about these resets :-)
So when a user is reset, that's when the selected "Default language" of that user shows its effect. Hmm, but the user would need to call that reset himself, since there is no button to reset another user, right?

Addition to Ernesto's description: The clear "clearSessionVars" button is ONLY accessible for admins! (so you've to use the simulation feature)

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44528

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44528