Bug #53862

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Bug #52949: Speed decrease since 4.5

isValidUrl idna converts whole URI instead of domain only

Added by Michiel Roos over 8 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Performance
Target version:
Start date:
2013-11-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

The expensive idna_convert is called from isValidUrl. Instead of feeding it just the domain part, it converts the whole URI.

When feeding it just the domain part, a great speed gain can be had.

This patch breaks apart the URI using parse_url(), converts the domain part, then re-assembles the uri using HttpUtility::buildUrl().

Please find profiling runs attached for:
  • /typo3/ (login screen)
  • /typo3/backend.php
  • /typo3/mod.php?M=web_list

Files

backend_php.png (34.2 KB) backend_php.png Michiel Roos, 2013-11-22 12:05
login_screen.png (34.4 KB) login_screen.png Michiel Roos, 2013-11-22 12:05
web_list.png (34.7 KB) web_list.png Michiel Roos, 2013-11-22 12:05
fu_idna.v3.diff (1.01 KB) fu_idna.v3.diff Michiel Roos, 2013-11-22 12:05
fu_idna_4.7.patch (1.07 KB) fu_idna_4.7.patch patch for 4.7 branch Michiel Roos, 2013-11-22 13:01
patch_set_6_backend_php.png (36.8 KB) patch_set_6_backend_php.png Michiel Roos, 2013-11-22 15:52
inValidFiles_login_page.txt (6.48 KB) inValidFiles_login_page.txt Non valid urls tested again from the login page Michiel Roos, 2013-11-23 01:06
Screen_Shot_2013-11-23_at_12.08.54.png (38.9 KB) Screen_Shot_2013-11-23_at_12.08.54.png Patch set 14 performance measurement Michiel Roos, 2013-11-23 12:09
TYPO3_CMS_Login__6.2.master.workbench.local___Workbench-7.jpg (139 KB) TYPO3_CMS_Login__6.2.master.workbench.local___Workbench-7.jpg http://例え.テスト/typo3/ Michiel Roos, 2013-11-26 19:51
Screen_Shot_2013-11-26_at_20.03.58.png (102 KB) Screen_Shot_2013-11-26_at_20.03.58.png Michiel Roos, 2013-11-26 20:05
Patch_25_backendPhp_unpopulated_Cache_dir.png (35.4 KB) Patch_25_backendPhp_unpopulated_Cache_dir.png Michiel Roos, 2013-12-20 11:26
Patch_25_dbList_siteRoot_populated_Cache_dir.jpg (45.4 KB) Patch_25_dbList_siteRoot_populated_Cache_dir.jpg Michiel Roos, 2013-12-20 11:26
Patch_25_login_unpopulated_Cache_dir.jpg (43.6 KB) Patch_25_login_unpopulated_Cache_dir.jpg Michiel Roos, 2013-12-20 11:26

Related issues

Related to TYPO3 Core - Bug #55475: Error when saving Domain system recordClosed2014-01-30

Actions
Related to TYPO3 Core - Bug #55713: GeneralUtility' not foundClosedMarkus Klein2014-02-06

Actions
#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#2

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#4

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#5

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#6

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#7

Updated by Gerrit Code Review over 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#9

Updated by Gerrit Code Review over 8 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#10

Updated by Gerrit Code Review over 8 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#11

Updated by Gerrit Code Review over 8 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#12

Updated by Gerrit Code Review over 8 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#13

Updated by Gerrit Code Review over 8 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#14

Updated by Gerrit Code Review over 8 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#15

Updated by Michiel Roos over 8 years ago

These files are tested but come back invalid.

We may gain some more speed by finding out who is testing them and why.

#16

Updated by Gerrit Code Review over 8 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#18

Updated by Gerrit Code Review over 8 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#19

Updated by Gerrit Code Review over 8 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#20

Updated by Gerrit Code Review over 8 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#21

Updated by Gerrit Code Review over 8 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#23

Updated by Michiel Roos over 8 years ago

Basic test against:

/typo3/backend.php from a 'just cleared the cache' state.

#24

Updated by Gerrit Code Review over 8 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#25

Updated by Gerrit Code Review over 8 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#26

Updated by Gerrit Code Review over 8 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#27

Updated by Gerrit Code Review over 8 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#28

Updated by Gerrit Code Review over 8 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#29

Updated by Gerrit Code Review over 8 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#30

Updated by Gerrit Code Review over 8 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25636

#31

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26501

#33

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26531

#34

Updated by Michiel Roos over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#35

Updated by Markus Klein over 8 years ago

  • Parent task set to #52949
#36

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF