Project

General

Profile

Actions

Bug #53963

closed

All Configuration shows a value of 1 for disabled boolean options

Added by Markus Klein about 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Install Tool
Target version:
Start date:
2013-11-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

In the All Configuration section of the Install Tool, all options of type boolean, which are disabled, show a value of 1, but the checkbox is unchecked.
It is not clear to the user whether a feature is now enabled or not.

An example is [BE][showRefreshLoginPopup].

The default value of this option is FALSE.
So if the LocalConfiguration.php does not modify this setting the Install Tool will look like this:

Actual value of [BE][showRefreshLoginPopup] is 0

Obviously this view is not consistent. The checkbox is unchecked. So what will happen if I click the "write configuration" button?
Will it set value to 0 now?
(The answer is: it will do nothing!)

Checking the checkbox now and clicking the button then will write the value 1 to the LocalConfiguration.php and the Install Tool will look like this:

Actual value of [BE][showRefreshLoginPopup] is 1

Which is correct now.

But unchecking the box now and writing the changes (value 0) will bring back the first image again.


Files

allconfiguration-0.png (12.2 KB) allconfiguration-0.png Actual value of [BE][showRefreshLoginPopup] is 0 Markus Klein, 2014-01-07 00:58
allconfiguration-1.png (11.5 KB) allconfiguration-1.png Actual value of [BE][showRefreshLoginPopup] is 1 Markus Klein, 2014-01-07 00:58
Actions #1

Updated by Markus Klein about 10 years ago

  • Assignee set to Markus Klein
Actions #2

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681

Actions #3

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681

Actions #4

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681

Actions #5

Updated by Gerrit Code Review about 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681

Actions #7

Updated by Gerrit Code Review about 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681

Actions #8

Updated by Gerrit Code Review about 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681

Actions #9

Updated by Gerrit Code Review about 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681

Actions #10

Updated by Gerrit Code Review about 10 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681

Actions #11

Updated by Markus Klein about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF