Bug #53963
closedAll Configuration shows a value of 1 for disabled boolean options
100%
Description
In the All Configuration section of the Install Tool, all options of type boolean, which are disabled, show a value of 1, but the checkbox is unchecked.
It is not clear to the user whether a feature is now enabled or not.
An example is [BE][showRefreshLoginPopup].
The default value of this option is FALSE.
So if the LocalConfiguration.php does not modify this setting the Install Tool will look like this:
Obviously this view is not consistent. The checkbox is unchecked. So what will happen if I click the "write configuration" button?
Will it set value to 0 now?
(The answer is: it will do nothing!)
Checking the checkbox now and clicking the button then will write the value 1 to the LocalConfiguration.php and the Install Tool will look like this:
Which is correct now.
But unchecking the box now and writing the changes (value 0) will bring back the first image again.
Files
Updated by Gerrit Code Review almost 11 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681
Updated by Gerrit Code Review almost 11 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681
Updated by Gerrit Code Review almost 11 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681
Updated by Gerrit Code Review almost 11 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681
Updated by Markus Klein almost 11 years ago
- File allconfiguration-0.png allconfiguration-0.png added
- File allconfiguration-1.png allconfiguration-1.png added
Updated by Gerrit Code Review almost 11 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681
Updated by Gerrit Code Review almost 11 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681
Updated by Gerrit Code Review almost 11 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681
Updated by Gerrit Code Review almost 11 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25681
Updated by Markus Klein almost 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 2ecd236abe1704cffe342f81fd675b06dae139b0.