Project

General

Profile

Actions

Bug #54312

closed

Logical error in indexer task

Added by Alexander Stehlik almost 11 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2013-12-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In the processChangedAndNewFiles() method in the Indexer class there seems to be a logical error which causes a fatal PHP error because an invalid call to getFileObject().

At the beginning there is a check:

if ($data == NULL) {

The data variable is not modified and then passed to the getFileObject() method:

$fileObject = $this->getResourceFactory()->getFileObject($data['uid'], $data);

Since data is NULL and does obviously not contain a UID this method call fails.

As far as I can see the code needs to look like that:

$fileObject = $this->getResourceFactory()->getFileObject($fileIndexEntry['uid'], $fileIndexEntry);
Actions #1

Updated by Markus Klein almost 11 years ago

  • Priority changed from Should have to Must have
Actions #2

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26339

Actions #3

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26339

Actions #4

Updated by Alexander Stehlik almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF