Bug #54924

Workspace edits revert to old content when accidentally published twice

Added by Stefan Rotsch over 5 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
Start date:
2014-01-13
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

This bug might not be triggered often as it only happens under specific circumstances, but still...

Manual process to reproduce:
1. Change a tt_content record in workspace
2. Go to workspace module
3. Push the changes to the last stage before Publishing
4. Open a new tab and go to the workspace module as well; you should now have to tabs open, both showing the same record.
5. Publish the record in the first tab. Test and see that everything is fine, the changes got to LIVE.
6. Publish the record in the second tab using the ACTION dropdown (this is important as only the ACTION dropdown triggers the issue).
7. Everything is reverted again and the changes are no longer visible in the Workspace (in the DB, the old workspace version of the record has wsid = 0 and pid = -1 and is thus invisible, but still contains the correct content).

Possible explanations:
- User had two tabs open
- Two users both published within 30 seconds of one another
- AJAX Request was fired twice? Somehow...

Important: Running the functional test requires a patched EXT:phpunit, see https://review.typo3.org/#/c/26743/

Associated revisions

Revision edc1150f (diff)
Added by Stefan Rotsch about 4 years ago

[BUGFIX] Edits disappear when published twice

When accidentally publishing an edit twice, eg. by using multiple
browser tabs, all modifications are reverted and the changes are no
longer visible in the workspace.

In the database, the old workspace version of the record has wsid = 0
and pid = -1 and is thus invisible, but still contains the modified
content.

Resolves: #54924
Releases: master, 6.2
Change-Id: I8805737540f030ae24331d33590b71629c7f3179
Reviewed-on: http://review.typo3.org/26769
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Andreas Wolf <>
Tested-by: Andreas Wolf <>

Revision 8bcc7693 (diff)
Added by Stefan Rotsch about 4 years ago

[BUGFIX] Edits disappear when published twice

When accidentally publishing an edit twice, eg. by using multiple
browser tabs, all modifications are reverted and the changes are no
longer visible in the workspace.

In the database, the old workspace version of the record has wsid = 0
and pid = -1 and is thus invisible, but still contains the modified
content.

Resolves: #54924
Releases: master, 6.2
Change-Id: I8805737540f030ae24331d33590b71629c7f3179
Reviewed-on: http://review.typo3.org/42592
Reviewed-by: Andreas Wolf <>
Tested-by: Andreas Wolf <>

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26769

#2 Updated by Wouter Wolters over 4 years ago

  • Status changed from Under Review to Closed

Peter Niederlag Jun 26, 2014

Abandoned

abandonde in favor of https://review.typo3.org/#/c/27835/

#3 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Closed to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26769

#4 Updated by Mathias Schreiber over 4 years ago

  • Target version set to 7.5

#5 Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26769

#6 Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26769

#7 Updated by Gerrit Code Review about 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26769

#8 Updated by Markus Sommer about 4 years ago

  • Assignee set to Stefan Rotsch

#9 Updated by Gerrit Code Review about 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26769

#10 Updated by Stefan Rotsch about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Gerrit Code Review about 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42592

#12 Updated by Stefan Rotsch about 4 years ago

  • Status changed from Under Review to Resolved

#13 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF