Bug #54935
closed
Incompatible declaration for FileList::listURL()
0%
Description
Declaration of TYPO3\CMS\Filelist\FileList::listURL() should be compatible with TYPO3\CMS\Backend\RecordList\AbstractRecordList::listURL($altId = '')
How-to Reproduce¶
Use PHP 5.4
Add this to AdditionalConfiguration.php:
$GLOBALS['TYPO3_CONF_VARS']['SYS']['errorHandlerErrors'] = E_ALL ^ E_NOTICE;
$GLOBALS['TYPO3_CONF_VARS']['SYS']['exceptionalErrors'] = E_ALL ^ E_NOTICE ^ E_WARNING ^ E_USER_ERROR ^ E_USER_NOTICE;
Open Extension Manager once logged.
Updated by Xavier Perseguers almost 11 years ago
Furthermore: Every VH in ExtensionManager are broken. They should extend their own AbstractViewHelper instead of relying on Fluid's defaults and misuse the render method.
Updated by Mathias Schreiber almost 10 years ago
- Status changed from New to Needs Feedback
- Assignee changed from Xavier Perseguers to Mathias Schreiber
Hey Xavier,
is this still the case?
Updated by Xavier Perseguers almost 10 years ago
File: TYPO3_master/typo3/sysext/filelist/Classes/FileList.php
class FileList extends \TYPO3\CMS\Backend\RecordList\AbstractRecordList {
// snip
/**
* Returns list URL; This is the URL of the current script with id and imagemode parameters, that's all.
* The URL however is not relative (with the backpath), otherwise GeneralUtility::sanitizeLocalUrl() would say that
* the URL would be invalid
*
* @return string URL
*/
public function listURL() {
File TYPO3_master/typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php
abstract class AbstractRecordList {
// snip
/**
* Creates the URL to this script, including all relevant GPvars
*
* @param string $altId Alternative id value. Enter blank string for the current id ($this->id)
* @return string URL
*/
public function listURL($altId = '') {
So yes, it's still the case, no need to "test" to see that the subclassed method is not showing the same method signature (well, not a "compatible one")
Updated by Alexander Opitz over 9 years ago
- Status changed from Needs Feedback to New
Updated by Georg Ringer over 7 years ago
this example has been solved with #71759, different arguments produce an exception with php7.
Updated by Xavier Perseguers over 7 years ago
- Status changed from New to Closed
As Georg mentioned, nothing else to do. Thanks.