Bug #55116
closedInstall Tool, inconsistent visual appearance in "System Environment"
100%
Description
In TYPO3 CMS 6.2 LTS beta4, the visual appearance of pages in the Install Tool varies. Function "System environment" shows a different appearance (e.g. font type of menu items left-hand-side, background colour etc.) than all other functions. See attached screenshot.
Browsers affected: Mozilla Firefox version 26.0 (no other browsers tested)
Files
Updated by Marcin Sągol almost 11 years ago
This one is caused by phpinfo() function output in last section.
This function renders own styles that contain also styles for 'body' tag (background color #ffffff)
Also here can be done small enhancement: the phpinfo() output is renderd inside div with class .toggleDataContent and this elements gets inactive vertical and horizonatal scrollbars (not sure if in all browserts). We can add here to this class style:
.toggleDataContent { overflow: hidden; }
so the scrollbars wont be rendered.
Updated by Tobias Wollender almost 11 years ago
Hi Marcin,
on my machine the server pathes are very long and so I need the horizontal scrollbar to be able to read all the info this phpinfo block is showing. So please don't change this element to overflow: hidden.
Thanks
Tobi
Updated by Marcin Sągol almost 11 years ago
The styles issue can be fixed for example by modyfing phpinfo() output.
We have access to this content in function handle() of typo3/sysext/install/Classes/Controller/Action/Tool/SystemEnvironment.php
ob_start();
phpinfo();
$phpInfo = ob_get_clean();
so we can remove from it some part of styles (body related and other prepand with container class) or completly remove them and apply our own.
See: http://php.net/phpinfo#77705
See: http://code.ohloh.net/file?fid=pasAdv5bVgSLf6sSEDdhk3a0eGk&cid=5NxwbpRqh-A&s=&fp=305797&mp&projSelected=true#L0
I'm waiting for other opinions.
Updated by Ernesto Baschny over 10 years ago
- Subject changed from Fix inconsistent visual appearance to Install Tool, inconsistent visual appearance in "System Environment"
- Target version set to 6.2.0
Yes, this needs to be fixed before release of 6.2.
This is the CSS added by phpinfo() (i.e. in PHP 5.4.4):
body {background-color: #ffffff; color: #000000;} body, td, th, h1, h2 {font-family: sans-serif;} pre {margin: 0px; font-family: monospace;} a:link {color: #000099; text-decoration: none; background-color: #ffffff;} a:hover {text-decoration: underline;} table {border-collapse: collapse;} .center {text-align: center;} .center table { margin-left: auto; margin-right: auto; text-align: left;} .center th { text-align: center !important; } td, th { border: 1px solid #000000; font-size: 75%; vertical-align: baseline;} h1 {font-size: 150%;} h2 {font-size: 125%;} .p {text-align: left;} .e {background-color: #ccccff; font-weight: bold; color: #000000;} .h {background-color: #9999cc; font-weight: bold; color: #000000;} .v {background-color: #cccccc; color: #000000;} .vr {background-color: #cccccc; text-align: right; color: #000000;} img {float: right; border: 0px;} hr {width: 600px; background-color: #cccccc; border: 0px; height: 1px; color: #000000;}
Some of these is still required for the table styling, but some interfere with out styles.
A quick&dirty solution is indeed to manipulate this part before outputting: i.e. remove all attributes "font-family", "font-size" or prefix the selectors with a common class or identifier and make sure this output is included in such a DIV.
A more error prone solution could be to load this phpinfo() inside an IFRAME which then has no impact at all on the Install Tool styling. This IFRAME URL still needs authenticated Install Tool login, of course. And we have to cope with the IFRAME limitations (fixed height).
Updated by Gerrit Code Review over 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28225
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28225
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28225
Updated by Gerrit Code Review over 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28225
Updated by Patrick Broens over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 97aa83fc26c21f794bb1fd3ffa44142af6cbe077.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed