Task #55122

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Story #55078: Optimize PHP code performance in TYPO3 methods

Cleanup and optimize methods in ExtensionManagementUtility

Added by Michiel Roos almost 6 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Performance
Target version:
Start date:
2014-01-18
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
medium
Sprint Focus:

Description

Methods in ExtenstionManagementUtility are called a lot. We need to ensure they are as performant as possible.

  • Reduce function calls
  • Use language constructs instead of functions
  • Use language constructs to check values before calling a function
  • Return early where possible
  • Rewrite addToAllTCAtypes() to just do a few preg_replace() calls and not call all the child methods

Related issues

Related to TYPO3 Core - Bug #55662: PHP Warning preg_replace in current master Closed 2014-02-04

Associated revisions

Revision aa37842b (diff)
Added by Michiel Roos almost 6 years ago

[CLEANUP] Cleanup ExtensionManagementUtility

Methods in this class are called a lot and are in need of some cleanup.
  • return early
  • reduce method and function calls
  • update doc comments
  • added tests with data provider for Method getCN

Change-Id: I5dcab647fc3da078b5f29beb57fecbf7c98bcaa5
Resolves: #55122
Releases: 6.2
Reviewed-on: https://review.typo3.org/27019
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Revision 707b0106 (diff)
Added by Michiel Roos almost 6 years ago

[BUGFIX] addModule after/before not working

The cleaned up addModule() method no longer adds the module after a
module, when the target module does not exist.

Expected behaviour: module added to the list.

Observed behaviour: module not added at all.

Change-Id: Ie0d1d0c98f9c7dde81636a40eb18a3a7816392f6
Resolves: #55608
Related: #55122
Releases: 6.2
Reviewed-on: https://review.typo3.org/27284
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein

History

#1 Updated by Michiel Roos almost 6 years ago

\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::executePositionedStringInsertion()
http://pastebin.com/UbMrdUL4

\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::executePositionedStringInsertion()
http://pastebin.com/UbMrdUL4

#3 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

#4 Updated by Ernesto Baschny almost 6 years ago

  • Parent task set to #55078

#5 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

#6 Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

#7 Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

#8 Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

#9 Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

#10 Updated by Michiel Roos almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF