Project

General

Profile

Actions

Bug #55648

closed

Line breaks in string in compile* methods of the SqlParser

Added by Stefano Kowalke almost 11 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Must have
Category:
Database API (Doctrine DBAL)
Target version:
Start date:
2014-02-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

The compile methods of inside SqlParser generates SQL queries out of an array. There are line breaks inside strings which leads to queries like:

SELECT * \n\t\t\t\tFROM table_name\n\t\t\t\tWHERE

This breaks the test for SqlParser of ext:dbal when it calls debug_testSQL() where the given query is combined with the compiled query -> debug_testSQL() dies when they are not the same.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #61449: Fix unit tests for DBAL sqlparser fixClosedMarkus Klein2014-09-08

Actions
Actions #1

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27318

Actions #2

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/27318

Actions #3

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/27318

Actions #4

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32648

Actions #5

Updated by Stefano Kowalke about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF