Bug #55759
closed
Using double quotes in title of links breaks everything
100%
Description
Usecase¶
I want to enter a title likeSee the "fantanstic\" typolink in action
for a typolink.
Problems¶
- Quotes in titles are not encoded correctly by JS when setting a link-field
- For decoding of the typolink string (several parts separated by space, enclosed by double-quotes) the method
GeneralUtility::unQuoteFilenames()is used, which does not treat inner quotes. - Output is not hsc()'d, hence the double quotes kill the FE output.
Proposed solution¶
Make this a breaking change for CMS 7 and treat the quotes properly in all place.
Additionally maybe provide an upgrade wizard, which converts existing titles likeSee the "fantanstic\" typolink in action
to the normal readable version for humans.
Updated by Markus Klein almost 11 years ago
Actually all calls to unQuoteFilenames(..., TRUE) can be replaced by a simply str_getcsv(..., ' ') call.
Updated by Markus Klein almost 11 years ago
- TYPO3 Version changed from 4.5 to 6.0
Updated by Markus Klein almost 11 years ago
Still this requires post processing to replace the \" with "
Updated by Markus Klein over 9 years ago
- Target version changed from next-patchlevel to 7.3 (Packages)
Updated by Markus Klein over 9 years ago
- Subject changed from GeneralUtility::unQuoteFilenames() should unescape double-quotes to Using double quotes in title of links breaks everything
- Description updated (diff)
- Target version changed from 7.3 (Packages) to 7.4 (Backend)
Updated by Gerrit Code Review over 9 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Updated by Gerrit Code Review over 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Updated by Gerrit Code Review over 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Updated by Gerrit Code Review over 9 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Updated by Gerrit Code Review over 9 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Updated by Gerrit Code Review over 9 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Updated by Gerrit Code Review over 9 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Updated by Gerrit Code Review over 9 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Updated by Gerrit Code Review over 9 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Updated by Markus Klein over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 591d86aad2917ef5ff936e597f158db31789908f.
Updated by Riccardo De Contardi over 7 years ago
- Status changed from Resolved to Closed