Project

General

Profile

Actions

Bug #55759

closed

Using double quotes in title of links breaks everything

Added by Markus Klein about 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Backend API
Target version:
Start date:
2014-02-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

Usecase

I want to enter a title like
See the "fantanstic\" typolink in action
for a typolink.

Problems

  • Quotes in titles are not encoded correctly by JS when setting a link-field
  • For decoding of the typolink string (several parts separated by space, enclosed by double-quotes) the method GeneralUtility::unQuoteFilenames() is used, which does not treat inner quotes.
  • Output is not hsc()'d, hence the double quotes kill the FE output.

Proposed solution

Make this a breaking change for CMS 7 and treat the quotes properly in all place.
Additionally maybe provide an upgrade wizard, which converts existing titles like
See the "fantanstic\" typolink in action
to the normal readable version for humans.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #51943: Quotes in RTE link title break HTML outputClosed2013-09-12

Actions
Follows TYPO3 Core - Bug #41413: link title got urlencoded in link-wizardClosed2012-09-27

Actions
Actions #1

Updated by Markus Klein about 10 years ago

Actually all calls to unQuoteFilenames(..., TRUE) can be replaced by a simply str_getcsv(..., ' ') call.

Actions #2

Updated by Markus Klein about 10 years ago

  • TYPO3 Version changed from 4.5 to 6.0
Actions #3

Updated by Markus Klein about 10 years ago

Still this requires post processing to replace the \" with "

Actions #4

Updated by Riccardo De Contardi almost 9 years ago

Still valid in 6.2.13

Actions #5

Updated by Markus Klein almost 9 years ago

  • Description updated (diff)
Actions #6

Updated by Markus Klein almost 9 years ago

  • Target version changed from next-patchlevel to 7.3 (Packages)
Actions #7

Updated by Markus Klein almost 9 years ago

  • Subject changed from GeneralUtility::unQuoteFilenames() should unescape double-quotes to Using double quotes in title of links breaks everything
  • Description updated (diff)
  • Target version changed from 7.3 (Packages) to 7.4 (Backend)
Actions #8

Updated by Markus Klein almost 9 years ago

  • Description updated (diff)
Actions #9

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162

Actions #10

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162

Actions #11

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162

Actions #12

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162

Actions #13

Updated by Gerrit Code Review almost 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162

Actions #14

Updated by Gerrit Code Review almost 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162

Actions #15

Updated by Gerrit Code Review over 8 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162

Actions #16

Updated by Gerrit Code Review over 8 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162

Actions #17

Updated by Gerrit Code Review over 8 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162

Actions #18

Updated by Gerrit Code Review over 8 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162

Actions #19

Updated by Gerrit Code Review over 8 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162

Actions #20

Updated by Markus Klein over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #21

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF