Bug #55759
closed
Using double quotes in title of links breaks everything
Added by Markus Klein over 10 years ago.
Updated over 6 years ago.
Description
Usecase¶
I want to enter a title like
See the "fantanstic\" typolink in action
for a typolink.
Problems¶
- Quotes in titles are not encoded correctly by JS when setting a link-field
- For decoding of the typolink string (several parts separated by space, enclosed by double-quotes) the method
GeneralUtility::unQuoteFilenames() is used, which does not treat inner quotes.
- Output is not hsc()'d, hence the double quotes kill the FE output.
Proposed solution¶
Make this a breaking change for CMS 7 and treat the quotes properly in all place.
Additionally maybe provide an upgrade wizard, which converts existing titles like
See the "fantanstic\" typolink in action
to the normal readable version for humans.
Actually all calls to unQuoteFilenames(..., TRUE) can be replaced by a simply str_getcsv(..., ' ') call.
- TYPO3 Version changed from 4.5 to 6.0
Still this requires post processing to replace the \" with "
- Description updated (diff)
- Target version changed from next-patchlevel to 7.3 (Packages)
- Subject changed from GeneralUtility::unQuoteFilenames() should unescape double-quotes to Using double quotes in title of links breaks everything
- Description updated (diff)
- Target version changed from 7.3 (Packages) to 7.4 (Backend)
- Description updated (diff)
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40162
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by