Bug #55876
closedBug #55830: Cleanup mess with treeView implementations
Rename classes with the same name
100%
Description
We have 3 implementations of the \localPageTree class in the global namespace in:
- db_new.php
- move_el.php
- class.browse_links.php
We should clean this up, as it's quite confusing for the developer which class is used when and makes autoloading impossible.
I attach Sequence diagram for db_new.php (and a source code of it). Diagram was generated with http://interactive.blockdiag.com/seqdiag/
For the class inheritance diagram see http://forge.typo3.org/issues/55830
Files
Updated by Tymoteusz Motylewski over 10 years ago
Updated by Tymoteusz Motylewski over 10 years ago
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572
Updated by Tymoteusz Motylewski over 10 years ago
Before the patch it worked like that:
- PagePositionMap always created getInstance("localPageTree") object for tree rendering.
- there were multiple implementations of the localPageTree object in different files.
- none of them were registered in the autoloader.
- so depending on the entry point script, different class was loaded (from db_new.php, move_el.....)
- so at the end PagePositionMap created different 'localPageTree' classes, depending on the entry point
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572
Updated by Gerrit Code Review over 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572
Updated by Tymoteusz Motylewski over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset d3f313f8a8b484737a492f1726d0f813bfb6b862.
Updated by Benni Mack almost 6 years ago
- Status changed from Resolved to Closed