Bug #55876

Bug #55830: Cleanup mess with treeView implementations

Rename classes with the same name

Added by Tymoteusz Motylewski over 7 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-02-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

We have 3 implementations of the \localPageTree class in the global namespace in:
- db_new.php
- move_el.php
- class.browse_links.php

We should clean this up, as it's quite confusing for the developer which class is used when and makes autoloading impossible.

I attach Sequence diagram for db_new.php (and a source code of it). Diagram was generated with http://interactive.blockdiag.com/seqdiag/
For the class inheritance diagram see http://forge.typo3.org/issues/55830


Files

db_new_php_sequence_diagram.svg (8.93 KB) db_new_php_sequence_diagram.svg Tymoteusz Motylewski, 2014-02-11 15:30
db_new_php_sequence_diagram.txt (682 Bytes) db_new_php_sequence_diagram.txt Tymoteusz Motylewski, 2014-02-11 15:33
move_el_php_sequence_diagram.svg (10.5 KB) move_el_php_sequence_diagram.svg Tymoteusz Motylewski, 2014-02-11 18:57
move_el_php_sequence_diagram.txt (786 Bytes) move_el_php_sequence_diagram.txt Tymoteusz Motylewski, 2014-02-11 18:57

Related issues

Related to TYPO3 Core - Task #64516: Move non-namespaced class into correct placesClosedBenni Mack2015-01-26

Actions
#3

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572

#4

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572

#5

Updated by Tymoteusz Motylewski over 7 years ago

Before the patch it worked like that:
- PagePositionMap always created getInstance("localPageTree") object for tree rendering.
- there were multiple implementations of the localPageTree object in different files.
- none of them were registered in the autoloader.
- so depending on the entry point script, different class was loaded (from db_new.php, move_el.....)
- so at the end PagePositionMap created different 'localPageTree' classes, depending on the entry point

#6

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572

#7

Updated by Gerrit Code Review about 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572

#8

Updated by Tymoteusz Motylewski about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Ernesto Baschny about 7 years ago

  • Parent task set to #55830
#10

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF