Project

General

Profile

Actions

Bug #55830

closed

Cleanup mess with treeView implementations

Added by Tymoteusz Motylewski about 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
Start date:
2014-02-10
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Currently we have ~17 classes inheriting from Backend\Tree\View\AbstractTreeView class
(not counting legacy classes from before namespace change).
We have several classes with the same names (from different namespaces) like:
Backend\Tree\View\PageTreeView
Backend\View\PageTreeView
or

Impexp\LocalPageTree
localPageTree from class.browse_links_php
localPageTree from db_new_php
localPageTree from move_el_php

It might be ok to have the same names across namespaces, but if it's combined with other issues, it makes really hard to understand this area of the core.

There are also 3 empty classes:
Rtehtmlarea\ImageFolderTree
rteFolderTree from class.browse_links_php
rtePageTree from class.browse_links_php

See attached diagrams of classes. One is with legacy classes, second one is without.

Because of this mess behaviour and look of trees differs in different parts of the backend (Link wizard, RTE link wizard, folder selector, file selector, image selector, RTE image selector,....).
It's also really hard to reuse it in own extension (which base class to inherit?).


Files


Subtasks 2 (0 open2 closed)

Bug #55847: Remove empty classes implementing AbstractTreeViewClosedTymoteusz Motylewski2014-02-10

Actions
Bug #55876: Rename classes with the same nameClosed2014-02-11

Actions

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #64516: Move non-namespaced class into correct placesClosedBenni Mack2015-01-26

Actions
Actions #2

Updated by Felix Kopp about 10 years ago

Great!!!!!

(Have been working with the trees due to the treelevel sprite icons)

Actions #3

Updated by Felix Kopp about 10 years ago

There are further trees hidden in TemplateService / DocumentTemplate for TypoScript, PageTS and more.

Actions #4

Updated by Tymoteusz Motylewski about 10 years ago

Uploaded new class diagram after #55847 and #55876 were merged.

Actions #5

Updated by Anja Leichsenring about 9 years ago

  • Sprint Focus set to On Location Sprint
Actions #6

Updated by Benni Mack about 9 years ago

  • Status changed from New to Resolved
  • Target version set to 7.1 (Cleanup)

done now.

Actions #7

Updated by Tymoteusz Motylewski over 8 years ago

Uploading source code for diagrams. It was generated with tool called "plantuml"
http://plantuml.sourceforge.net/classes.html

Actions #8

Updated by Anja Leichsenring about 8 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #9

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF