Bug #55876: Rename classes with the same name - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #55876

closed

Bug #55830: Cleanup mess with treeView implementations

Rename classes with the same name

Added by Tymoteusz Motylewski almost 11 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

Start date:

2014-02-11

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

We have 3 implementations of the \localPageTree class in the global namespace in:
- db_new.php
- move_el.php
- class.browse_links.php

We should clean this up, as it's quite confusing for the developer which class is used when and makes autoloading impossible.

I attach Sequence diagram for db_new.php (and a source code of it). Diagram was generated with http://interactive.blockdiag.com/seqdiag/
For the class inheritance diagram see http://forge.typo3.org/issues/55830

Files

Download all files

db_new_php_sequence_diagram.svg (8.93 KB) db_new_php_sequence_diagram.svg		Tymoteusz Motylewski, 2014-02-11 15:30
db_new_php_sequence_diagram.txt (682 Bytes) db_new_php_sequence_diagram.txt		Tymoteusz Motylewski, 2014-02-11 15:33
move_el_php_sequence_diagram.svg (10.5 KB) move_el_php_sequence_diagram.svg		Tymoteusz Motylewski, 2014-02-11 18:57
move_el_php_sequence_diagram.txt (786 Bytes) move_el_php_sequence_diagram.txt		Tymoteusz Motylewski, 2014-02-11 18:57

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Tymoteusz Motylewski almost 11 years ago

File db_new_php_sequence_diagram.txt db_new_php_sequence_diagram.txt added

Actions

Copy link Download all files

Updated by Tymoteusz Motylewski almost 11 years ago

File move_el_php_sequence_diagram.svg move_el_php_sequence_diagram.svg added
File move_el_php_sequence_diagram.txt move_el_php_sequence_diagram.txt added

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572

Actions

Copy link

Updated by Tymoteusz Motylewski almost 11 years ago

Before the patch it worked like that:
- PagePositionMap always created getInstance("localPageTree") object for tree rendering.
- there were multiple implementations of the localPageTree object in different files.
- none of them were registered in the autoloader.
- so depending on the entry point script, different class was loaded (from db_new.php, move_el.....)
- so at the end PagePositionMap created different 'localPageTree' classes, depending on the entry point

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27572

Actions

Copy link