Bug #55941

Content Object instances are reused

Added by Oliver Hader about 7 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2014-02-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The ContentObjectRenderer creates instances for each content object to be rendered, e.g. TEXT, COA, CONTENT, etc.
However, these instances are re-used and therefore we introduced work-arounds since serialization of FLUIDTEMPLATE failed back then.
If dealing with nested record sets via RECORDS or CONTENT, reusing objects might be tricky since the parent pointer to the ContentObjectRenderer might be wrong and strange things happen.

This patch removes the pseudo singleton approach since the objects are not state-less and might lead to unexpected results in rare cases.


Related issues

Related to TYPO3 Core - Task #55297: Cleanup ContentObject\ContentObjectRendererClosed2014-01-07

Actions
#1

Updated by Gerrit Code Review about 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27586

#2

Updated by Gerrit Code Review about 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27586

#3

Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27586

#4

Updated by Gerrit Code Review about 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27586

#5

Updated by Gerrit Code Review about 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27586

#6

Updated by Gerrit Code Review about 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27586

#7

Updated by Oliver Hader about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#8

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed
#9

Updated by Susanne Moog about 2 years ago

  • Related to Task #55297: Cleanup ContentObject\ContentObjectRenderer added

Also available in: Atom PDF