Task #55297
closed
Cleanup ContentObject\ContentObjectRenderer
100%
Description
- getContentObject() defines classMapping over and over. This should become a class property
- can we make this class a Singleton?
- replace is_array and array_key_exists with isset where safe
- cache class instantiations in recursive method cObjGetSingle()
Updated by Mathias Schreiber over 9 years ago
- Target version changed from 6.2.0 to 7.2 (Frontend)
Updated by Anja Leichsenring over 9 years ago
- Sprint Focus set to On Location Sprint
Updated by Benni Mack about 9 years ago
- Target version changed from 7.2 (Frontend) to 7.4 (Backend)
Updated by Romain Leleu about 9 years ago
- Status changed from New to In Progress
- Assignee set to Romain Leleu
Updated by Romain Leleu about 9 years ago
I tried to implement your suggest but can't see any improvement; maybe I missed something.
You can see profiling before and after refectoring:
- before: https://blackfire.io/profiles/ee8f25ef-570f-4da6-9c0d-f56350bea96b/graph
- after: https://blackfire.io/profiles/7141f74f-510f-464d-ba0f-05e552a1863e/graph
- compare: https://blackfire.io/profiles/compare/b682782c-ba55-4683-8340-88bc27c6c177/graph
I'm open to any suggest to go further.
Updated by Gerrit Code Review about 9 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40381
Updated by Susanne Moog almost 9 years ago
- Target version changed from 7.4 (Backend) to 7.5
Updated by Anja Leichsenring almost 9 years ago
- Sprint Focus changed from On Location Sprint to Remote Sprint
Updated by Wouter Wolters over 8 years ago
- Status changed from Under Review to New
- Assignee deleted (
Romain Leleu) - TYPO3 Version changed from 6.2 to 7
- PHP Version changed from 5.3 to 5.5
Updated by Susanne Moog over 5 years ago
- Related to Bug #55941: Content Object instances are reused added
Updated by Susanne Moog over 5 years ago
- Status changed from New to Closed
As there hasn't happened much on this issue for the last few years + there's https://forge.typo3.org/issues/55941 to consider and the different parts here should be separate issues I'm going to close this one now. If somebody wants to work on any of these parts, feel free to create a new issue.