Bug #56135

Exception in listQuery in DatabaseConnection never thrown

Added by Stefano Kowalke over 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Database API (Doctrine DBAL)
Target version:
Start date:
2014-02-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

The condition should check for comma in $value in the method listQuery. This will not work because the parameters of strpos are in wrong order.

It need to be:

strpos($haystack, $needle) 

but we have:

strpos($needle, $haystack) 

if (strpos(',', $value) !== FALSE) {
    throw new \InvalidArgumentException('$value must not contain a comma (,) in $this->listQuery() !', 1294585862);
}

Related issues

Related to TYPO3 Core - Bug #56160: Exception in listQuery in DatabaseConnection never thrown (TYPO3 4.x)Closed2014-02-20

Actions
#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27749

#2

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27750

#3

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27751

#4

Updated by Mathias Brodala over 8 years ago

This also affects TYPO3 4.7 and 4.5!

#5

Updated by Markus Klein over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Riccardo De Contardi over 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF