Bug #57365

Page cache information displayed also displayed for json typeNum pages, if [FE][debug] is set

Added by Andreas Allacher over 8 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-03-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Hi,

I just noticed that if you have TYPO3_GLOBAL_VARS['FE']['debug'] set you always get the page cache generation displayed at the end via HTML comment.

However, if I build a json array via that typeNum that creates troubles.
Maybe it would be better to prefer the page config.debug setting, if it is set (so I can overwrite it in the typeNum page - maybe only if typeNum > 0) or create a different setting to disable it.


Related issues

Related to TYPO3 Core - Bug #57202: Parsetime: config.debug should override LocalConfigurationClosed2014-03-23

Actions
#1

Updated by Andreas Allacher over 8 years ago

if ($this->TYPO3_CONF_VARS['FE']['debug'] || isset($this->config['config']['debug']) && $this->config['config']['debug']) {
                        $dateFormat = $GLOBALS['TYPO3_CONF_VARS']['SYS']['ddmmyy'];
                        $timeFormat = $GLOBALS['TYPO3_CONF_VARS']['SYS']['hhmm'];
                        $this->content .= LF . '<!-- Cached page generated ' . date(($dateFormat . ' ' . $timeFormat), $row['tstamp']) . '. Expires ' . Date(($dateFormat . ' ' . $timeFormat), $row['expires']) . ' -->';
                    }

Current (6.2 stable) TypoScriptFrontendController line 2211, method getFromCache

#2

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28909

#3

Updated by Markus Klein over 8 years ago

Is the same solution as for #57202

#4

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28909

#5

Updated by Stefan Neufeind over 8 years ago

Imho #57202 already solved this? Allows you to override LocalConfiguration using config.debug.

#6

Updated by Georg Ringer over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF