Bug #57365
closed
Page cache information displayed also displayed for json typeNum pages, if [FE][debug] is set
100%
Description
Hi,
I just noticed that if you have TYPO3_GLOBAL_VARS['FE']['debug'] set you always get the page cache generation displayed at the end via HTML comment.
However, if I build a json array via that typeNum that creates troubles.
Maybe it would be better to prefer the page config.debug setting, if it is set (so I can overwrite it in the typeNum page - maybe only if typeNum > 0) or create a different setting to disable it.
Updated by Andreas Allacher over 10 years ago
if ($this->TYPO3_CONF_VARS['FE']['debug'] || isset($this->config['config']['debug']) && $this->config['config']['debug']) {
$dateFormat = $GLOBALS['TYPO3_CONF_VARS']['SYS']['ddmmyy'];
$timeFormat = $GLOBALS['TYPO3_CONF_VARS']['SYS']['hhmm'];
$this->content .= LF . '<!-- Cached page generated ' . date(($dateFormat . ' ' . $timeFormat), $row['tstamp']) . '. Expires ' . Date(($dateFormat . ' ' . $timeFormat), $row['expires']) . ' -->';
}
Current (6.2 stable) TypoScriptFrontendController line 2211, method getFromCache
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28909
Updated by
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28909
Updated by Stefan Neufeind over 10 years ago
Imho #57202 already solved this? Allows you to override LocalConfiguration using config.debug.
Updated by Georg Ringer over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset cdf723e23e755aa2fb7f778e4cb2878bc1aa495f.
Updated by