Feature #57446
closed
harmonize visibility of template/partial/layoutRootPath(s) getter/setter functions in /typo3/sysext/fluid/Classes/View/TemplateView.php
100%
Description
I tried to add rendering of partials from other extensions to f:render viewHelper and run into some problems if non default partial root paths (e.g. EXT:my_ext/Resources/Private/Partials/News) are used. So I had to store the original partial root paths to be able to reset them after rendering the external partial.
I tried to use the new plural getter/setter methods introduced in Revision f122c4f5 (getPartialRootPaths() instead of getPartialRootPath()).
As function getPartialRootPaths() is protected I had to use ReflectionMethod to store/reset the partial root paths. It would be very convenient if it were a public getter. I couldnt't figure out why getPartialRootPaths() and getLayoutRootPaths() are protectetd, while getTemplateRootPaths() is public. Imho this should be harmonized. As getTemplateRootPath(), getPartialRootPath() and getLayoutRootPath() are deprecated they should left protected. The new plural setter/getter function imho should all be public so we can use $this->viewHelperVariableContainer->getView()->getPartialRootPaths() inside viewHelpers.
Please have a look at /typo3/sysext/fluid/Classes/View/TemplateView.php:
protected function getTemplateRootPath() @deprecated since fluid 6.2
public function setTemplateRootPath()
public function getTemplateRootPaths()
public function setTemplateRootPaths()
protected function getPartialRootPath() @deprecated since fluid 6.2
public function setPartialRootPath()
protected function getPartialRootPaths() -> should be changed to public
public function setPartialRootPaths()
protected function getLayoutRootPath() @deprecated since fluid 6.2
public function setLayoutRootPath()
protected function getLayoutRootPaths() -> should be changed to public
public function setLayoutRootPaths()
Updated by Georg Tiefenbrunn over 10 years ago
Same issue in TYPO3.Fluid (see /Classes/TYPO3/Fluid/View/TemplateView.php)
Updated by Mathias Schreiber almost 10 years ago
- Target version set to 7.3 (Packages)
Updated by Benni Mack over 9 years ago
- Target version changed from 7.3 (Packages) to 7.4 (Backend)
Updated by Susanne Moog over 9 years ago
- Target version changed from 7.4 (Backend) to 7.5
Updated by Gerrit Code Review about 9 years ago
- Status changed from New to Under Review
Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 38 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 39 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 40 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 41 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 42 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 43 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 44 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 45 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 46 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 47 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 48 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 49 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 50 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 51 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 52 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 53 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 54 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 55 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 56 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 57 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 58 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 59 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 60 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 61 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 62 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 63 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 64 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 65 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 66 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 67 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 68 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 69 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 70 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 71 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 72 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 73 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 74 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 75 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 76 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 77 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 78 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 79 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 80 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 81 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 82 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 83 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 84 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 85 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 86 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 87 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 88 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 89 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 90 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 91 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 92 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 93 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 94 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 95 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 96 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 97 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 98 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 99 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 100 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 101 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 102 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 103 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 104 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 105 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 106 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 107 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 108 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 109 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 110 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 111 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 112 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 113 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 114 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 115 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 116 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 117 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 118 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 119 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 120 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 121 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 122 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 123 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 124 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 125 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 126 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 127 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 128 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 129 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 130 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 131 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Anonymous almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 8b693daac0cc381f10c74bc5d78b2448f55111f3.
Updated by Benni Mack about 6 years ago
- Status changed from Resolved to Closed