Project

General

Profile

Actions

Bug #58752

closed

Fluid Widget Link/Uri Viewhelpers adds addQueryStringMethod to the arguments

Added by Kevin Kamps over 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2014-05-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In

  • TYPO3\CMS\Fluid\ViewHelpers\Widget\LinkViewHelper (line 116 - 118)
  • TYPO3\CMS\Fluid\ViewHelpers\Widget\UriViewHelper (line 103 - 105)

the ViewHelper argument addQueryStringMethod is added to the query string of the uri. This should not happen because this has no place in the uri. The addQueryStringMethod should only be used to configure the TSref/typolink.addQueryString.method


Files

LinkViewHelper.php (5 KB) LinkViewHelper.php Modified version of LinkViewHelper that fixes this bug Kevin Kamps, 2014-05-13 11:24
UriViewHelper.php (4.23 KB) UriViewHelper.php Modified version of UriViewHelper that fixes this bug Kevin Kamps, 2014-05-13 11:24

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #61960: f:widget.link always generates links with cHashClosed2014-09-30

Actions
Related to TYPO3 Core - Feature #69863: Use new standalone Fluid as composer dependencyClosedClaus Due2015-09-16

Actions
Actions #1

Updated by Daniel Goerz over 9 years ago

  • Category set to Fluid
Actions #2

Updated by Claus Due about 9 years ago

  • Status changed from New to Accepted
  • Priority changed from Should have to Must have

Confirmed, looks like a standard human error and indeed a bug: https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/fluid/Classes/ViewHelpers/Widget/LinkViewHelper.php#L116

The fix is obvious: avoid wrapping `addQueryStringMethod` into the scoped URL arguments.

Actions #3

Updated by Gerrit Code Review about 9 years ago

  • Status changed from Accepted to Under Review

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425

Actions #4

Updated by Gerrit Code Review about 9 years ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425

Actions #5

Updated by Gerrit Code Review about 9 years ago

Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425

Actions #6

Updated by Gerrit Code Review about 9 years ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425

Actions #7

Updated by Gerrit Code Review about 9 years ago

Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425

Actions #8

Updated by Gerrit Code Review about 9 years ago

Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425

Actions #9

Updated by Gerrit Code Review about 9 years ago

Patch set 38 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425

Actions #10

Updated by Gerrit Code Review about 9 years ago

Patch set 39 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425

Actions #11

Updated by Gerrit Code Review about 9 years ago

Patch set 40 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425

Actions #12

Updated by Gerrit Code Review about 9 years ago

Patch set 41 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425

Actions #13

Updated by Gerrit Code Review about 9 years ago

Patch set 42 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #14

Updated by Mathias Schreiber about 9 years ago

  • Target version deleted (next-patchlevel)
Actions #15

Updated by Gerrit Code Review about 9 years ago

Patch set 43 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #16

Updated by Gerrit Code Review about 9 years ago

Patch set 44 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #17

Updated by Gerrit Code Review about 9 years ago

Patch set 45 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #18

Updated by Gerrit Code Review about 9 years ago

Patch set 46 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #19

Updated by Gerrit Code Review about 9 years ago

Patch set 47 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #20

Updated by Gerrit Code Review about 9 years ago

Patch set 48 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #21

Updated by Gerrit Code Review about 9 years ago

Patch set 49 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #22

Updated by Gerrit Code Review about 9 years ago

Patch set 50 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #23

Updated by Gerrit Code Review about 9 years ago

Patch set 51 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #24

Updated by Gerrit Code Review about 9 years ago

Patch set 52 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #25

Updated by Gerrit Code Review about 9 years ago

Patch set 53 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #26

Updated by Gerrit Code Review about 9 years ago

Patch set 54 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #27

Updated by Gerrit Code Review almost 9 years ago

Patch set 55 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #28

Updated by Gerrit Code Review almost 9 years ago

Patch set 56 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #29

Updated by Gerrit Code Review almost 9 years ago

Patch set 57 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #30

Updated by Gerrit Code Review almost 9 years ago

Patch set 58 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #31

Updated by Gerrit Code Review almost 9 years ago

Patch set 59 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #32

Updated by Gerrit Code Review almost 9 years ago

Patch set 60 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #33

Updated by Gerrit Code Review almost 9 years ago

Patch set 61 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #34

Updated by Gerrit Code Review almost 9 years ago

Patch set 62 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #35

Updated by Gerrit Code Review almost 9 years ago

Patch set 63 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #36

Updated by Gerrit Code Review almost 9 years ago

Patch set 64 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #37

Updated by Gerrit Code Review almost 9 years ago

Patch set 65 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #38

Updated by Gerrit Code Review almost 9 years ago

Patch set 66 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #39

Updated by Gerrit Code Review almost 9 years ago

Patch set 67 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #40

Updated by Gerrit Code Review almost 9 years ago

Patch set 68 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #41

Updated by Gerrit Code Review almost 9 years ago

Patch set 69 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #42

Updated by Gerrit Code Review almost 9 years ago

Patch set 70 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #43

Updated by Gerrit Code Review almost 9 years ago

Patch set 71 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #44

Updated by Gerrit Code Review almost 9 years ago

Patch set 72 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #45

Updated by Gerrit Code Review almost 9 years ago

Patch set 73 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #46

Updated by Gerrit Code Review almost 9 years ago

Patch set 74 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #47

Updated by Gerrit Code Review almost 9 years ago

Patch set 75 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #48

Updated by Gerrit Code Review almost 9 years ago

Patch set 76 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #49

Updated by Gerrit Code Review almost 9 years ago

Patch set 77 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #50

Updated by Gerrit Code Review almost 9 years ago

Patch set 78 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #51

Updated by Gerrit Code Review almost 9 years ago

Patch set 79 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #52

Updated by Gerrit Code Review almost 9 years ago

Patch set 80 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #53

Updated by Gerrit Code Review almost 9 years ago

Patch set 81 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #54

Updated by Gerrit Code Review almost 9 years ago

Patch set 82 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #55

Updated by Gerrit Code Review almost 9 years ago

Patch set 83 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #56

Updated by Gerrit Code Review almost 9 years ago

Patch set 84 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #57

Updated by Gerrit Code Review almost 9 years ago

Patch set 85 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #58

Updated by Gerrit Code Review almost 9 years ago

Patch set 86 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #59

Updated by Gerrit Code Review almost 9 years ago

Patch set 87 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #60

Updated by Gerrit Code Review almost 9 years ago

Patch set 88 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #61

Updated by Gerrit Code Review almost 9 years ago

Patch set 89 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #62

Updated by Gerrit Code Review almost 9 years ago

Patch set 90 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #63

Updated by Gerrit Code Review almost 9 years ago

Patch set 91 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #64

Updated by Gerrit Code Review almost 9 years ago

Patch set 92 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #65

Updated by Gerrit Code Review almost 9 years ago

Patch set 93 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #66

Updated by Gerrit Code Review almost 9 years ago

Patch set 94 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #67

Updated by Gerrit Code Review almost 9 years ago

Patch set 95 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #68

Updated by Gerrit Code Review almost 9 years ago

Patch set 96 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #69

Updated by Gerrit Code Review almost 9 years ago

Patch set 97 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #70

Updated by Gerrit Code Review almost 9 years ago

Patch set 98 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #71

Updated by Gerrit Code Review almost 9 years ago

Patch set 99 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #72

Updated by Gerrit Code Review almost 9 years ago

Patch set 100 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #73

Updated by Gerrit Code Review almost 9 years ago

Patch set 101 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #74

Updated by Gerrit Code Review almost 9 years ago

Patch set 102 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #75

Updated by Gerrit Code Review almost 9 years ago

Patch set 103 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #76

Updated by Gerrit Code Review almost 9 years ago

Patch set 104 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #77

Updated by Gerrit Code Review almost 9 years ago

Patch set 105 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #78

Updated by Gerrit Code Review almost 9 years ago

Patch set 106 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #79

Updated by Gerrit Code Review almost 9 years ago

Patch set 107 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #80

Updated by Gerrit Code Review almost 9 years ago

Patch set 108 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #81

Updated by Gerrit Code Review almost 9 years ago

Patch set 109 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #82

Updated by Gerrit Code Review almost 9 years ago

Patch set 110 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #83

Updated by Gerrit Code Review almost 9 years ago

Patch set 111 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #84

Updated by Gerrit Code Review almost 9 years ago

Patch set 112 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #85

Updated by Gerrit Code Review almost 9 years ago

Patch set 113 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #86

Updated by Gerrit Code Review almost 9 years ago

Patch set 114 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #87

Updated by Gerrit Code Review almost 9 years ago

Patch set 115 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #88

Updated by Gerrit Code Review almost 9 years ago

Patch set 116 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #89

Updated by Gerrit Code Review almost 9 years ago

Patch set 117 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #90

Updated by Gerrit Code Review almost 9 years ago

Patch set 118 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #91

Updated by Gerrit Code Review almost 9 years ago

Patch set 119 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #92

Updated by Gerrit Code Review almost 9 years ago

Patch set 120 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #93

Updated by Gerrit Code Review almost 9 years ago

Patch set 121 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #94

Updated by Gerrit Code Review almost 9 years ago

Patch set 122 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #95

Updated by Gerrit Code Review almost 9 years ago

Patch set 123 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #96

Updated by Gerrit Code Review almost 9 years ago

Patch set 124 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #97

Updated by Gerrit Code Review almost 9 years ago

Patch set 125 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #98

Updated by Gerrit Code Review almost 9 years ago

Patch set 126 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #99

Updated by Gerrit Code Review almost 9 years ago

Patch set 127 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #100

Updated by Gerrit Code Review almost 9 years ago

Patch set 128 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #101

Updated by Gerrit Code Review almost 9 years ago

Patch set 129 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #102

Updated by Gerrit Code Review almost 9 years ago

Patch set 130 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #103

Updated by Gerrit Code Review almost 9 years ago

Patch set 131 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425

Actions #104

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46332

Actions #105

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46349

Actions #106

Updated by Nicole Cordes almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #107

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46350

Actions #108

Updated by Nicole Cordes almost 9 years ago

  • Status changed from Under Review to Resolved
Actions #109

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF