Task #59004

Code Cleanups in TranslationConfigurationProvider

Added by Sebastian Michaelsen over 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2014-05-21
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

\TYPO3\CMS\Backend\Configuration\TranslationConfigurationProvider could use a few cleanups:

  • Introduce type hinted $this->databaseConnection instead of using $GLOBALS['TYPO3_DB']
  • Use type hinted local variable instead of $GLOBALS['LANG']
  • Deprecate $backPath parameter of ->getSystemLanguages and adapt the method calls
  • Break very long lines of code into smaller chunks
  • Fix phpDoc issue

Related issues

Related to TYPO3 Core - Bug #79062: Filelist allows metadata translation for disabled languages Rejected 2016-12-21
Related to TYPO3 Core - Bug #59947: getSystemLanguages() method in TranslationConfigurationProvider does not respect enable fields Closed 2014-06-27

Associated revisions

Revision b5c3a549 (diff)
Added by Sebastian Michaelsen over 4 years ago

[CLEANUP] TranslationConfigurationProvider

  • Import class names with use statements
  • Encapsulate $GLOBALS['TYPO3_DB'] and $GLOBALS['LANG'] in type-hinted
    getters
  • Remove unused $backPath parameter of ->getSystemLanguages
    and adapt the core method calls
  • Refactor ->getSystemLanguages method
  • Refactor ->translationInfo method
  • Break very long lines of code into smaller chunks
  • Fix phpDoc issues
  • Use lowerCamelCase for variable names

Releases: master
Resolves: #59004
Change-Id: Ib5cbcb19559a47b067a1e666528de3d6e23f406b
Reviewed-on: http://review.typo3.org/30258
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30258

#2 Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#3 Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#4 Updated by Gerrit Code Review almost 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#5 Updated by Gerrit Code Review almost 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#6 Updated by Gerrit Code Review almost 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#7 Updated by Gerrit Code Review almost 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#8 Updated by Gerrit Code Review almost 5 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#9 Updated by Gerrit Code Review almost 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#10 Updated by Gerrit Code Review almost 5 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#11 Updated by Gerrit Code Review almost 5 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#12 Updated by Gerrit Code Review almost 5 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#13 Updated by Gerrit Code Review almost 5 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#14 Updated by Gerrit Code Review almost 5 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#15 Updated by Gerrit Code Review almost 5 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#16 Updated by Gerrit Code Review almost 5 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#17 Updated by Gerrit Code Review almost 5 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#18 Updated by Gerrit Code Review almost 5 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#19 Updated by Gerrit Code Review almost 5 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#20 Updated by Anja Leichsenring over 4 years ago

  • Sprint Focus set to On Location Sprint

#21 Updated by Gerrit Code Review over 4 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30258

#22 Updated by Anonymous over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#23 Updated by Anja Leichsenring almost 4 years ago

  • Sprint Focus deleted (On Location Sprint)

#24 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF