Bug #59392
closedGifbuilder: Make image-mask-functionality work again
100%
Description
Currently the mask-functionality seems broken. The mask is not applied since
$processingConfiguration['maskImages']['maskImage'] and $processingConfiguration['maskImages']['backgroundImage']
are expected by the LocalCropScaleMaskHelper but not set.
And although then the resulting image is created correctly, the wrong file (path) is result.
Tested on current master, but I expect it does back to the 6.0-branch (introduction of FAL).
Updated by Gerrit Code Review about 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30610
Updated by Stefan Neufeind about 10 years ago
Works for me using the patch in gerrit and the following code to watermark all images.
For an easier example just set XY to a fixed value and get rid of "10 = ..." completely. This way the watermark will be stretched depending on your image-size - but that's okay just for testing.
lib.watermark = IMG_RESOURCE
lib.watermark {
file = GIFBUILDER
file {
format = jpg
quality = 88
- 10 is just used to detect the size
10 = IMAGE
10.file {
import.current = 1
treatIdAsReference = 1
width.field = imagewidth
maxW = {$styles.content.imgtext.maxW}
maxW.override.data = register:maxImageWidth
maxWInText = {$styles.content.imgtext.maxWInText}
maxWInText.override.data = register:maxImageWidthInText
}
15 = IMAGE
15.offset = 10,10
15.file = fileadmin/wasserzeichen.png
}
}
tt_content.image.20.1.file {
m.mask.import.cObject < lib.watermark
m.mask.import.cObject.treatIdAsReference = 1
m.bgImg < .m.mask
}
Updated by Gerrit Code Review about 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30610
Updated by Gerrit Code Review about 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30610
Updated by Gerrit Code Review about 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30610
Updated by Gerrit Code Review about 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31201
Updated by Gerrit Code Review about 10 years ago
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31202
Updated by Stefan Neufeind about 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 521b3464ce1819de9728fd3434e62d36750b3a4d.
Updated by Gerrit Code Review about 10 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31202
Updated by Stefan Neufeind about 10 years ago
- Status changed from Under Review to Resolved
Applied in changeset 16cd7eb88d7da177c2e58509bebad97a13e597db.
Updated by Benni Mack almost 6 years ago
- Status changed from Resolved to Closed
Updated by Simon Schaufelberger over 2 years ago
- Related to Feature #60806: Gifbuilder: Allow image-mask-functionality without specifying a mask added