Project

General

Profile

Actions

Bug #59392

closed

Gifbuilder: Make image-mask-functionality work again

Added by Stefan Neufeind almost 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2014-06-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Currently the mask-functionality seems broken. The mask is not applied since
$processingConfiguration['maskImages']['maskImage'] and $processingConfiguration['maskImages']['backgroundImage']
are expected by the LocalCropScaleMaskHelper but not set.
And although then the resulting image is created correctly, the wrong file (path) is result.

Tested on current master, but I expect it does back to the 6.0-branch (introduction of FAL).


Related issues 2 (1 open1 closed)

Related to TYPO3 Core - Bug #59967: Insufficient mocking in ContentObjectRendererTestClosedMarkus Klein2014-06-28

Actions
Related to TYPO3 Core - Feature #60806: Gifbuilder: Allow image-mask-functionality without specifying a maskNew2014-08-05

Actions
Actions #1

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30610

Actions #2

Updated by Stefan Neufeind almost 10 years ago

Works for me using the patch in gerrit and the following code to watermark all images.

For an easier example just set XY to a fixed value and get rid of "10 = ..." completely. This way the watermark will be stretched depending on your image-size - but that's okay just for testing.

lib.watermark = IMG_RESOURCE
lib.watermark {
file = GIFBUILDER
file {
format = jpg
quality = 88

XY = [10.w],[10.h]
  1. 10 is just used to detect the size
    10 = IMAGE
    10.file {
    import.current = 1
    treatIdAsReference = 1
    width.field = imagewidth
    maxW = {$styles.content.imgtext.maxW}
    maxW.override.data = register:maxImageWidth
    maxWInText = {$styles.content.imgtext.maxWInText}
    maxWInText.override.data = register:maxImageWidthInText
    }
15 = IMAGE
15.offset = 10,10
15.file = fileadmin/wasserzeichen.png
}
}

tt_content.image.20.1.file {
m.mask.import.cObject < lib.watermark
m.mask.import.cObject.treatIdAsReference = 1
m.bgImg < .m.mask
}

Actions #3

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30610

Actions #4

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30610

Actions #5

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30610

Actions #6

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31201

Actions #7

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31202

Actions #8

Updated by Stefan Neufeind almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31202

Actions #10

Updated by Stefan Neufeind almost 10 years ago

  • Status changed from Under Review to Resolved
Actions #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions #12

Updated by Simon Schaufelberger about 2 years ago

  • Related to Feature #60806: Gifbuilder: Allow image-mask-functionality without specifying a mask added
Actions

Also available in: Atom PDF