Bug #59619
closed
Static call of non-static function in Package.php
100%
Description
in Classes/Package/PackageManager.php around line 73 there is this line:
if (!\TYPO3\CMS\Core\Package\PackageManager::isPackageKeyValid($packageKey)) {
the called method "isPackageKeyValid" is non-satic so from my understanding it should be changed to:
if (!$packageManager->isPackageKeyValid($packageKey)) {
can somebody check this?
Updated by Wouter Wolters almost 10 years ago
- Status changed from New to Accepted
- Assignee set to Wouter Wolters
Will be discussed on T3DD14 with Thomas, the integrator of the package manager backport.
Updated by Gerrit Code Review almost 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31749
Updated by Peter Niederlag almost 10 years ago
What has been the outcome of the discussion @t3dd14? This is probably only happening on php 5.6.X?
Review is pending on gerrit now.
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31749
Updated by Gerrit Code Review almost 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31749
Updated by Gerrit Code Review almost 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31778
Updated by Peter Niederlag almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 59635160716e4da2f98df419f9148f240ebd08c2.
Updated by