Task #60479: Micro optimizations in SqlParser - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #60479

closed

Micro optimizations in SqlParser

Added by Andreas Fernandez over 10 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Could have

Assignee:

Category:

Target version:

Start date:

2014-07-22

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

Introduced a few optimizations in the SqlParser classes of "core" and "dbal". I had the problem that many queries (e.g. updating the extension list) takes a lot more time when using dbal and adodb (oci8 driver in this case) so I tried to get a few microseconds.

Optimizations made:

Changed some regular expressions (see attached benchmark file)
Strict comparison
Put often used variable manipulation into a new method
Definition of $comparatorPatterns was in a while() without any modification on it, so made it a protected member

Files

regex-bench.log (3.5 KB) regex-bench.log

Andreas Fernandez, 2014-07-22 22:21

Actions

Copy link

Updated by Andreas Fernandez over 10 years ago

Gerrit does not update this issue, here's the link:
https://review.typo3.org/#/c/31730/

Actions

Copy link

Updated by Stefan Neufeind over 10 years ago

Status changed from New to Under Review

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31730

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31730

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31730

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31730

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31730

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31730

Actions

Copy link