Bug #62550

activated defLangBinding: Content Elements that exist only in translation are not displayed at all

Added by Andreas Allacher over 4 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2014-10-30
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

With activated defLangBinding setting content elements that only exist in the translation are not displayed at all.

The problem seems to be
if (!$lP && ($this->defLangBinding || $row['sys_language_uid'] != -1)) {

and
$defLangBinding[$key][$lP][$row[$lP ? 'l18n_parent' : 'uid']] = $singleElementHTML;

Instead of checking regarding language "$lP", it would be better to check if the l18n_parent is set for the corresponding row.

Of course, one also needs to modify getNonTranslatedTTcontentUids method accordingly

01-default.png View - Default view (translated content shown) (12.9 KB) Mathias Brodala, 2018-05-25 09:23

02-defLangBinding.png View - View with defLangBinding activated (translated content invisible) (12 KB) Mathias Brodala, 2018-05-25 09:23

03-defLangBinding-patched.png View - View with defLangBinding activated and patch applied (translated content still invisible) (12.2 KB) Mathias Brodala, 2018-05-25 09:23


Related issues

Related to TYPO3 Core - Bug #81753: Content element translations dissapear in page module after move to another column New 2017-06-30

Associated revisions

Revision 74044c19 (diff)
Added by Nicole Cordes 10 months ago

[BUGFIX] Show all content elements with mod.web_layout.defLangBinding

The option is meant to show translated content elements
alligned with their translation parent element (connected mode).

However this also made content elements diasppear, which were
added individually in a language (free mode).

With this change, elements for a language in free mode
are also shown, when the option is set.

Resolves: #62550
Releases: master, 8.7
Change-Id: I96f754ecf4ddb98f22d0d8c7d7da6001fa774d6b
Reviewed-on: https://review.typo3.org/54654
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision 0fbeb2d7 (diff)
Added by Nicole Cordes 10 months ago

[BUGFIX] Show all content elements with mod.web_layout.defLangBinding

The option is meant to show translated content elements
alligned with their translation parent element (connected mode).

However this also made content elements diasppear, which were
added individually in a language (free mode).

With this change, elements for a language in free mode
are also shown, when the option is set.

Resolves: #62550
Releases: master, 8.7
Change-Id: I96f754ecf4ddb98f22d0d8c7d7da6001fa774d6b
Reviewed-on: https://review.typo3.org/56932
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>

History

#1 Updated by Daniel Goerz almost 3 years ago

  • Category set to Backend User Interface
  • TYPO3 Version changed from 6.2 to 7

In 7 LTS (and current master) the issue can be reproduced as following:

  1. Create a page with at least one alternative language
  2. Copy content to the alternative language (not translate, but copy)
  3. enable mod.web_layout.defLangBinding = 1
  4. Go to page module in language mode

#2 Updated by Riccardo De Contardi over 1 year ago

Still reproducible in latest master 9.0.0-dev

#3 Updated by Riccardo De Contardi over 1 year ago

  • Related to Bug #81753: Content element translations dissapear in page module after move to another column added

#4 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54654

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54654

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54654

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54654

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54654

#9 Updated by Gerrit Code Review 10 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54654

#10 Updated by Gerrit Code Review 10 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54654

#11 Updated by Gerrit Code Review 10 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54654

#12 Updated by Gerrit Code Review 10 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54654

#13 Updated by Nicole Cordes 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#14 Updated by Gerrit Code Review 10 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56932

#15 Updated by Mathias Brodala 10 months ago

Here are my results when testing this change in TYPO3v8 (8.7.15): when activating the defLangBinding option, translated content is invisible as described in the report. However, this is not fixed even after applying the change. But now even the container for the content element is invisible.

#16 Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56932

#17 Updated by Nicole Cordes 10 months ago

  • Status changed from Under Review to Resolved

#18 Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF