Project

General

Profile

Actions

Bug #62967

closed

xhtml cleaning broken for javascript

Added by Nicole Cordes over 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2014-11-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Due to commit https://review.typo3.org/#/c/30240/ the xhtml_cleaning for javascript gets broken as the comments were removed and javascript is parsed in a wrong way. A solution would be to exclude CDATA-code from parsing.

As the xhtml_cleaning should be removed in master anyway, the patch only applies to 6.2 and 4.5!


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #55457: RTE on first new IRRE record keeps loading in IEClosedStanislas Rolland2014-01-30

Actions
Actions #1

Updated by Markus Klein over 9 years ago

I'm sure this is a duplicate... I read this somewhere else recently.
I also added the relation to the ticket.

Actions #2

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34192

Actions #3

Updated by Oliver Hader over 9 years ago

TypoScript to reproduce

page.jsInline {
  123 = TEXT
  123.value = console.log('<hello world>');
}

config.xhtml_cleaning = all
config.removeDefaultJS = 0

The frontend rendering will produce

console.log('<hello world="">');

instead of just
console.log('<hello world>');
Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34207

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34192

Actions #6

Updated by Nicole Cordes over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35039

Actions #8

Updated by Nicole Cordes over 9 years ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Benni Mack almost 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF