Task #62983

Cleanup and update language module

Added by Kai Vogel over 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Language Manager (backend)
Target version:
Start date:
2014-11-15
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

The old Language module looks no longer compatible in the new Backend design. In addition, the extension key "lang" should be called "language" to make a unification here. By changing the language files are retained in the old language module and any new functionality is transferred to the new module.


Related issues

Related to TYPO3 Core - Task #63104: Move language files from old to new language extension Rejected 2014-11-20
Related to TYPO3 Core - Task #63242: No horizontal scrolling for window by fixed language container + languages container scrolled within table Closed 2014-11-23
Related to TYPO3 Core - Task #66930: Add breaking rest manual for language module refactoring Closed 2015-05-13
Related to TYPO3 Core - Bug #69079: Correct wording for AJAX error message Closed 2015-08-14

Associated revisions

Revision 80873de8 (diff)
Added by Kai Vogel over 4 years ago

[TASK] Cleanup and update language module

This patch modernizes the old language module to fit
the new backend design.

Resolves: #62983
Releases: master
Change-Id: I0a607e3ed25d793bf73f6aa7721a1bb26a6078ba
Reviewed-on: http://review.typo3.org/34200
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Tested-by: Benjamin Mack <>
Reviewed-by: Benjamin Mack <>

Revision 55abd0e7 (diff)
Added by Andreas Fernandez about 4 years ago

[TASK] Add manual for moved signal "postProcessMirrorUrl"

The signal "postProcessMirrorUrl" was moved while refactoring the
"Language" backend module. Add a Breaking ReST manual to
describe the change and the migration path.

Resolves: #66930
Related: #62983
Releases: master
Change-Id: I751a7c8c49500dd482fabe72c3b842118eb1a7a6
Reviewed-on: http://review.typo3.org/39522
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Xavier Perseguers <>
Tested-by: Xavier Perseguers <>

Revision 70fa16cd (diff)
Added by Xavier Perseguers 10 months ago

[DOCS] Explain that L10n signal/slot is not affected

The breaking change documentation is adapted to explicitly mention that
the signal/slot registration is kept untouched.

This will prevent confusion for developers reading the list of breaking changes.

Related: #50467
Related: #62983
Related: #84131
Related: #84691
Releases: master
Change-Id: I43ff5a6882e84c29844495fa9f10e6a35f07b1ff
Reviewed-on: https://review.typo3.org/58313
Reviewed-by: Mathias Brodala <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#2 Updated by Kai Vogel over 4 years ago

If you get an error that the LanguageService was not found from ObjectManager when cherry-picking the patch, the system extension "language" is not loaded at this moment. It comes with a migration file to update the path to that file. To fix the error just add this block to the typo3conf/PackageStates.php and clear all caches via Install Tool:

    'language' =>
    array (
      'manifestPath' => '',
      'composerName' => 'typo3/cms-language',
      'state' => 'active',
      'packagePath' => 'typo3/sysext/language/',
      'classesPath' => 'Classes/',
      'suggestions' =>
      array (
      ),
    ),

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#7 Updated by Kai Vogel over 4 years ago

My comment from review.typo3.org:

The idea for the new language extension was born at the code sprint in Hamburg
last week. The "lang" extension is very old and historically grown. But it
doesn't contain a good code base for future developments. Because that I
decided to rewrite the PHP and JS parts and to cleanup the interface to fit
into new Backend design. The code is based on the old "lang" extension but
the controller is completely rewritten and some unnecessary code was removed
from the other classes.

The old "lang" extension should be removed in the next releases. But it needs
a bit work to do that, because all internal language files are stored in the
root directory of the lang extension and are mostly referenced with a hardcoded
path.

I saw the broken system problem in the past an wrote some words in the related
forge ticket. But with the last commit I added an update wizard for the install
tool to fix this.

The update of a language takes a long time. That is a problem since years
before. But with the previous rewrite of the lang extension, I had improved
this a bit. Now I've done this again and improved the speed up to two times.
This is done with removing the check if an translation file is available on
server. If the file will be not available when fetching, it will anyway fail
and so I only try to fetch the file now. The big problem is not the Extbase
dispatching, it need much time to request the server, wait for an answer and
download the translation zip file. If we can improve that, a language update
will be faster.

#8 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#9 Updated by Gerrit Code Review over 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#10 Updated by Gerrit Code Review over 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#11 Updated by Gerrit Code Review over 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#12 Updated by Gerrit Code Review over 4 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#13 Updated by Gerrit Code Review over 4 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#14 Updated by Gerrit Code Review over 4 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#15 Updated by Gerrit Code Review over 4 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#16 Updated by Gerrit Code Review over 4 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#17 Updated by Mathias Schreiber over 4 years ago

  • Target version changed from 7.0 to 7.1 (Cleanup)

#18 Updated by Gerrit Code Review over 4 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#19 Updated by Gerrit Code Review over 4 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#20 Updated by Gerrit Code Review over 4 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#21 Updated by Gerrit Code Review over 4 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#22 Updated by Gerrit Code Review over 4 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#23 Updated by Gerrit Code Review over 4 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

#24 Updated by Kai Vogel over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 90 to 100

#25 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF