Project

General

Profile

Actions

Task #62983

closed

Cleanup and update language module

Added by Kai Vogel over 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Language Manager (backend)
Target version:
Start date:
2014-11-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

The old Language module looks no longer compatible in the new Backend design. In addition, the extension key "lang" should be called "language" to make a unification here. By changing the language files are retained in the old language module and any new functionality is transferred to the new module.


Related issues 4 (0 open4 closed)

Related to TYPO3 Core - Task #63104: Move language files from old to new language extensionRejectedKai Vogel2014-11-20

Actions
Related to TYPO3 Core - Task #63242: No horizontal scrolling for window by fixed language container + languages container scrolled within tableClosed2014-11-23

Actions
Related to TYPO3 Core - Task #66930: Add breaking rest manual for language module refactoringClosedAndreas Kienast2015-05-13

Actions
Related to TYPO3 Core - Bug #69079: Correct wording for AJAX error messageClosedMarkus Klein2015-08-14

Actions
Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #2

Updated by Kai Vogel over 9 years ago

If you get an error that the LanguageService was not found from ObjectManager when cherry-picking the patch, the system extension "language" is not loaded at this moment. It comes with a migration file to update the path to that file. To fix the error just add this block to the typo3conf/PackageStates.php and clear all caches via Install Tool:

    'language' =>
    array (
      'manifestPath' => '',
      'composerName' => 'typo3/cms-language',
      'state' => 'active',
      'packagePath' => 'typo3/sysext/language/',
      'classesPath' => 'Classes/',
      'suggestions' =>
      array (
      ),
    ),
Actions #3

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #7

Updated by Kai Vogel over 9 years ago

My comment from review.typo3.org:

The idea for the new language extension was born at the code sprint in Hamburg
last week. The "lang" extension is very old and historically grown. But it
doesn't contain a good code base for future developments. Because that I
decided to rewrite the PHP and JS parts and to cleanup the interface to fit
into new Backend design. The code is based on the old "lang" extension but
the controller is completely rewritten and some unnecessary code was removed
from the other classes.

The old "lang" extension should be removed in the next releases. But it needs
a bit work to do that, because all internal language files are stored in the
root directory of the lang extension and are mostly referenced with a hardcoded
path.

I saw the broken system problem in the past an wrote some words in the related
forge ticket. But with the last commit I added an update wizard for the install
tool to fix this.

The update of a language takes a long time. That is a problem since years
before. But with the previous rewrite of the lang extension, I had improved
this a bit. Now I've done this again and improved the speed up to two times.
This is done with removing the check if an translation file is available on
server. If the file will be not available when fetching, it will anyway fail
and so I only try to fetch the file now. The big problem is not the Extbase
dispatching, it need much time to request the server, wait for an answer and
download the translation zip file. If we can improve that, a language update
will be faster.
Actions #8

Updated by Gerrit Code Review over 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #9

Updated by Gerrit Code Review over 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #10

Updated by Gerrit Code Review over 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #11

Updated by Gerrit Code Review over 9 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #12

Updated by Gerrit Code Review over 9 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #13

Updated by Gerrit Code Review over 9 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #14

Updated by Gerrit Code Review over 9 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #15

Updated by Gerrit Code Review over 9 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #16

Updated by Gerrit Code Review over 9 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #17

Updated by Mathias Schreiber about 9 years ago

  • Target version changed from 7.0 to 7.1 (Cleanup)
Actions #18

Updated by Gerrit Code Review about 9 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #19

Updated by Gerrit Code Review about 9 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #20

Updated by Gerrit Code Review about 9 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #21

Updated by Gerrit Code Review about 9 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #22

Updated by Gerrit Code Review about 9 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #23

Updated by Gerrit Code Review about 9 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34200

Actions #24

Updated by Kai Vogel about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 90 to 100
Actions #25

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF