Bug #63026

Improve performance in LocalizationUtility

Added by Stefan Froemken over 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Category:
Localization
Target version:
Start date:
2014-11-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.5
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

Hello Core-Team,

translate method of LocalizationUtility will be called nearly 700 times in extensionmanager. With each call, also isFirstPartOfStr will be called. I know: This method is really fast, but in case of 700 calls it still needs 15-17 milliseconds.
I will provide a patch which changes the if-calls to improve performance.
In my tests this change brings 7-8 milliseconds (~50%) and is still valid in UnitTests

Stefan


Related issues

Related to TYPO3 Core - Bug #66864: LocalizationUtility patch breaks labelsClosed2015-05-09

Actions
#1

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34266

#2

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34266

#3

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34266

#4

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34266

#5

Updated by Mathias Schreiber over 6 years ago

  • Target version changed from 7.0 to 7.1 (Cleanup)
#6

Updated by Gerrit Code Review about 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34266

#7

Updated by Stefan Froemken about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#8

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF