Bug #63026
closedImprove performance in LocalizationUtility
100%
Description
Hello Core-Team,
translate method of LocalizationUtility will be called nearly 700 times in extensionmanager. With each call, also isFirstPartOfStr will be called. I know: This method is really fast, but in case of 700 calls it still needs 15-17 milliseconds.
I will provide a patch which changes the if-calls to improve performance.
In my tests this change brings 7-8 milliseconds (~50%) and is still valid in UnitTests
Stefan
Updated by Gerrit Code Review over 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34266
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34266
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34266
Updated by Gerrit Code Review over 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34266
Updated by Mathias Schreiber over 9 years ago
- Target version changed from 7.0 to 7.1 (Cleanup)
Updated by Gerrit Code Review over 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34266
Updated by Stefan Froemken over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 217954659043ff6ed48a2d5f2e1f6c3207cb9b21.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed