Bug #63364

ReadOnly filemounts check does not respect evaluatePermissions setting

Added by Alexander Stehlik over 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2014-11-27
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

In the \TYPO3\CMS\Core\Resource\ResourceStorage it is possible to set a the class property $evaluatePermissions.

If this is FALSE no check for filemount boundaries should be performed.

The new feature for read only filemounts has introduced a regression here because the check for this new flag does not respect this setting.

Another problem is that this check in the checkFileActionPermission() method can also fail when the user has multiple filemounts, one which allows writing and one which is read only because it breaks on the first read only filemount.


Related issues

Related to TYPO3 Core - Bug #49391: options.folderTree.altElementBrowserMountPoints (readonly filemounts) not working with FAL Closed 2013-06-24

Associated revisions

Revision 1dea9375 (diff)
Added by Helmut Hummel over 5 years ago

[BUGFIX] Properly check permissions with read only file mounts

Previously the permission check returned false if the
file or folder was within a read only file mount, but
also within a writable file mount.

Properly check this now and centralize the check in
isWithinFileMountBoundaries, which now has an additional
argument whether write access to file mounts should be checked or not.

Resolves: #63364
Related: #49391
Releases: master, 6.2
Change-Id: If90958b7d6e4d5aad1fbd172af06462ca2b9764f
Reviewed-on: http://review.typo3.org/34694
Reviewed-by: Helmut Hummel <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Tested-by: Markus Klein <>

Revision 8e1e0e5f (diff)
Added by Helmut Hummel over 5 years ago

[BUGFIX] Properly check permissions with read only file mounts

Previously the permission check returned false if the
file or folder was within a read only file mount, but
also within a writable file mount.

Properly check this now and centralize the check in
isWithinFileMountBoundaries, which now has an additional
argument whether write access to file mounts should be checked or not.

Resolves: #63364
Related: #49391
Releases: master, 6.2
Change-Id: If90958b7d6e4d5aad1fbd172af06462ca2b9764f
Reviewed-on: http://review.typo3.org/34964
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Alexander Stehlik <>
Tested-by: Alexander Stehlik <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34694

#2 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34694

#3 Updated by Helmut Hummel over 5 years ago

  • Description updated (diff)
  • Status changed from Under Review to Needs Feedback

can you eleborate in non technical speak what usecase you have, what your expectations are and what the current behavior is?

#4 Updated by Helmut Hummel over 5 years ago

  • Status changed from Needs Feedback to Accepted

Ok, I think I got it ;)

#5 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Accepted to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34694

#6 Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34694

#7 Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34694

#8 Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34964

#9 Updated by Helmut Hummel over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34964

#11 Updated by Helmut Hummel over 5 years ago

  • Status changed from Under Review to Resolved

#12 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF