Project

General

Profile

Actions
Copy link

Bug #63812

closed

Bug #63692: Memory consumption while bulk inserting

Lower memory use in ArrayUtil->mergeRecursiveWithOverrule

Added by Stephan Großberndt over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Stephan Großberndt
Category:
Performance
Target version:
next-patchlevel
Start date:
2014-12-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

Currently ArrayUtil->mergeRecursiveWithOverrule uses foreach (array_keys($overrule) as $key) to iterate the keys. This means a new array consisting only of the keys has to be created which costs performance and memory:

static public function mergeRecursiveWithOverrule(array &$original, array $overrule, $addKeys = TRUE, $includeEmptyValues = TRUE, $enableUnsetFeature = TRUE) {
    foreach (array_keys($overrule) as $key) {

Replacing this with

    foreach ($overrule as $key => $unusedValue)

drastically lowers memory usage and enhances performance.

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #54251: GeneralUtility::array_merge_recursive_overrule has bad performanceClosedMarkus Klein2013-12-06

Actions
Actions
Copy link

Also available in: Atom PDF