Bug #64286

ImageViewHelpers miss absolute param

Added by Frans Saris over 4 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2015-01-14
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The ImageViewhelper and Uri/ImageViewHelper are missing the $absolute option to create absolute urls like the LinkViewHelper

Associated revisions

Revision c6668314 (diff)
Added by Helmut Hummel almost 4 years ago

[FEATURE] Add force absolute image URL

Adds a new parameter to ImageViewHelper to force
an absolute URL for image path.

Resolves: #64286
Releases: master
Change-Id: I16a38fa4565d251a7ea953cd58f73efa2c4ed12f
Reviewed-on: http://review.typo3.org/41682
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>

History

#1 Updated by Frans Saris over 4 years ago

  • Target version set to 7.1 (Cleanup)

#2 Updated by Alexander Schnitzler over 4 years ago

Can you explain the desired functionality?

Do you wish that the domain is appended? Or just that the image path is absolute to the webroot like

/fileadmin/_processed_/foo.jpg

?

#3 Updated by Frans Saris over 4 years ago

Desired functionality is domain + path just like the link.* ViewHelpers

#4 Updated by Benni Mack over 4 years ago

  • Target version changed from 7.1 (Cleanup) to 7.4 (Backend)

#5 Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41682

#6 Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41682

#7 Updated by Susanne Moog about 4 years ago

  • Target version changed from 7.4 (Backend) to 7.5

#8 Updated by Benni Mack almost 4 years ago

  • Target version deleted (7.5)

#9 Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41682

#10 Updated by Helmut Hummel almost 4 years ago

  • Status changed from Under Review to Needs Feedback

What is the use case for this option?

#11 Updated by Frans Saris almost 4 years ago

  • Status changed from Needs Feedback to Accepted

When rendering HTML messages for external use (like email) we need to use absolute url's for the src of an image just like you do with links.

#12 Updated by Frans Saris almost 4 years ago

  • Status changed from Accepted to Under Review

#13 Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41682

#14 Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41682

#15 Updated by Gerrit Code Review almost 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41682

#16 Updated by Gerrit Code Review almost 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41682

#17 Updated by Gerrit Code Review almost 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41682

#18 Updated by Gerrit Code Review almost 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41682

#19 Updated by Helmut Hummel almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#20 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF