Task #64322

Story #64327: Unit test compatibility with HHVM

Make ArrayUtilityTest work on HHVM

Added by Tymoteusz Motylewski almost 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2015-01-16
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

ArrayUtilityTests expect that order of elements whith the same value
will not change. PHP doesn't guarantee that, so it doesn't make
sense to test this behaviour.

This test fails under HHVM which has different sorting
implementation then PHP 5.

Actually PHP 7 is going into the same direction, so sooner
or later this test will fail also under PHP.
See https://github.com/php/php-src/pull/999
and https://github.com/facebook/hhvm/issues/4649

Associated revisions

Revision 4ee7cdf9 (diff)
Added by Tymoteusz Motylewski almost 5 years ago

[TASK] Make array utility test do not depend on undefined behaviour

ArrayUtilityTests expect that order of elements with the same value
will not change. PHP doesn't guarantee that, so it doesn't make
sense to test this behaviour.

This test fails under HHVM which has different sorting
implementation than PHP 5.

Actually PHP 7 is going into the same direction, so sooner
or later this test will fail also under PHP.
See https://github.com/php/php-src/pull/999
and https://github.com/facebook/hhvm/issues/4649

Resolves: #64322
Releases: master
Change-Id: Ie48e57456eee20ff9b1a0efc0ac38413f16c5de1
Reviewed-on: http://review.typo3.org/36055
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review almost 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36055

#2 Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36055

#3 Updated by Tymoteusz Motylewski almost 5 years ago

  • Parent task set to #64327

#4 Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36055

#5 Updated by Tymoteusz Motylewski almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF