Project

General

Profile

Actions

Task #64322

closed

Story #64327: Unit test compatibility with HHVM

Make ArrayUtilityTest work on HHVM

Added by Tymoteusz Motylewski over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2015-01-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

ArrayUtilityTests expect that order of elements whith the same value
will not change. PHP doesn't guarantee that, so it doesn't make
sense to test this behaviour.

This test fails under HHVM which has different sorting
implementation then PHP 5.

Actually PHP 7 is going into the same direction, so sooner
or later this test will fail also under PHP.
See https://github.com/php/php-src/pull/999
and https://github.com/facebook/hhvm/issues/4649

Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36055

Actions #2

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36055

Actions #3

Updated by Tymoteusz Motylewski over 9 years ago

  • Parent task set to #64327
Actions #4

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36055

Actions #5

Updated by Tymoteusz Motylewski about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF