Task #64322: Make ArrayUtilityTest work on HHVM - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #64322

closed

Story #64327: Unit test compatibility with HHVM

Make ArrayUtilityTest work on HHVM

Added by Tymoteusz Motylewski almost 10 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Tymoteusz Motylewski

Category:

Target version:

Start date:

2015-01-16

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

ArrayUtilityTests expect that order of elements whith the same value
will not change. PHP doesn't guarantee that, so it doesn't make
sense to test this behaviour.

This test fails under HHVM which has different sorting
implementation then PHP 5.

Actually PHP 7 is going into the same direction, so sooner
or later this test will fail also under PHP.
See https://github.com/php/php-src/pull/999
and https://github.com/facebook/hhvm/issues/4649

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36055

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36055

Actions

Copy link

Updated by Tymoteusz Motylewski almost 10 years ago

Parent task set to #64327

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36055

Actions

Copy link