TYPO3 Core

Hi Cornel,
I needed some time to test all the cases :).

Test with different file collections Language Default: EN Translation: DE

Test 1:
Filecollection of a folder – metadata only in Default language
All images will be displayed in Default language and Translation
Default Metadata are also shown in German Translation

Test 2:
Filecollection of a folder – metadata are also translated to DE
Everythink works fine

Test 3:
Filecollection of a folder – metadata are also translated to DE. Default metadata get category.
But in filecollection I can't chose Select from folder and Category.
So same as in Test 2. Would be nice to chose also a category and a folder.

Test 3.2:
Filecollection by category 1
Default Language shows all files with the assigned category from all folders. This works in Default language.
No german metadata and no category is assigned.
So IMHO no files should be shown in FE.
But the the same files are shown as in Default Language.

Test 4:
Filecollection by category 1 – Part 2
Metadata are translated. German gets another category (category 2) than the Default language.
The translation of the filecollection has category 2. The Default Language Category 1. In German all files with category 1 are shown. But also files without a category will be shown if they have a category in default language.

Test 5:
Filecollection by category 1 – Part 3
Default Metadata don't have a category. So in the default language no files are shown. This works as expected.
Even in the translation not files are shown. But the translation of the filecollection category 2 is chosen and that's the category of the translated metadata.

During my tests I found some other things:
- If I copy a folder with images and metadata, all metadata are lost in the copied folder. This happens also if I copy a single file in another folder.
- All files in filecollections are not referenced in fileadmin – or no reference is displayd.
- It would also be helpful to show the assigned category in list view and also the metadata.

We have the same problem with content element File Links and file collection with categories and "translated" files.
We solved it with following quick and dirty code in class CategoryBasedFileCollection:

if ($resource) {

            $fileUids = array();

            while (($record = $this->getDatabaseConnection()->sql_fetch_assoc($resource)) !== FALSE) {

                $fileUid = intval($record['file']);

                 if(!in_array($fileUid, $fileUids, true)) {

                     $this->add($resourceFactory->getFileObject((int)$record['file']));
                     $fileUids[] = $fileUid;
                 }

            }
            $this->getDatabaseConnection()->sql_free_result($resource);
        }

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48850

We have also the Problem in TYPO3 8.7.20 and the content elements File Links and file collection with categories and "translated" files.

I've tested the Patch but it throws an exception

'SELECT `sys_file_metadata`.`file` FROM `sys_category` INNER JOIN `sys_category_record_mm` `sys_category_record_mm` ON `sys_category_record_mm`.`uid_local` = `sys_category`.`uid` INNER JOIN `sys_file_metadata` `sys_file_metadata` ON `sys_category_record_mm`.`uid_foreign` = `sys_file_metadata`.`uid` WHERE Array': Unknown column 'Array' in 'where clause' 

My solution was

if (count($constraints)) {
                $queryBuilder->where($constraints[0]);
                array_shift($constraints);
                foreach ($constraints as $constraint) {
                    $queryBuilder->andWhere($constraint);
                }
            }
            $statement = $queryBuilder->execute();

->where($constraints)

Or is there any other solution for this case?

EDIT:
With this Patch it's impossible to use mixed sys_file_metadata. You need to translate every metadata if you want to use this. Because there is no "ALL [sys_language_uid = -1]" in sys_file_metadata and we have no "Default". This could break some installations.