Project

General

Profile

Actions
Copy link

Bug #66510

closed

Add quotes to dynamic values in thrown exceptions

Added by Romain Canon over 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2015-04-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

It would be more pleasant, and help debugging if values were surrounded by quotes when an error/exception is thrown.

Example that happened to me: Exeption #1289386765 in TYPO3\CMS\Extbase\Object\Container\ClassInfoFactory->buildClassInfoFromClassName, my class name had a space at its end (missclick for sure), and I spent too much time to understand why the exception was thrown. I'm sure I would have got it faster if I was able to see this space.

Actions
Copy link
 #1

Updated by Markus Klein over 9 years ago

Can you contribute a patch please? Should be a fairly easy patch.

http://wiki.typo3.org/CWT

Thanks

Actions
Copy link
 #2

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45225

Actions
Copy link
 #3

Updated by Georg Ringer almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF