Task #66751
closed
Epic #65429: Speed up for Fluid ViewHelpers by usage of CompilableInterface
Make \Be\Menus\ActionMenuItemViewHelper compilable
100%
Description
Implement CompilableInterface and getTagBuilder to get the TagBuilder for renderStatic function
Updated by Gerrit Code Review almost 9 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
Updated by Gerrit Code Review almost 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
Updated by Gerrit Code Review almost 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
Updated by Gerrit Code Review almost 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
Updated by Gerrit Code Review almost 9 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
Updated by Markus Sommer almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9695759844f2c4981339aff77be50340f8c6b1b6.
Updated by Frank Nägler almost 9 years ago
This patch get reverted for now:
Reason for the regression is that initialize() of the abstract is no longer called, which takes care of "additionalAttributes" and "data-" attributes. The introduced getTagBuilder() method is not sufficient. So, basically the rule "no simple migration to compilable possible if the VH keeps local state" was violated here.
Updated by Frank Nägler almost 9 years ago
- Tracker changed from Task to Bug
- Is Regression set to Yes
Updated by