Task #66751
closed
Epic #65429: Speed up for Fluid ViewHelpers by usage of CompilableInterface
Make \Be\Menus\ActionMenuItemViewHelper compilable
Added by Markus Sommer about 9 years ago.
Updated over 5 years ago.
Description
Implement CompilableInterface and getTagBuilder to get the TagBuilder for renderStatic function
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39202
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
This patch get reverted for now:
Reason for the regression is that initialize() of the abstract is no longer called, which takes care of "additionalAttributes" and "data-" attributes. The introduced getTagBuilder() method is not sufficient. So, basically the rule "no simple migration to compilable possible if the VH keeps local state" was violated here.
- Tracker changed from Task to Bug
- Is Regression set to Yes
- Tracker changed from Bug to Task
- Status changed from Resolved to Closed
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by