Actions
Bug #67098
closedBug in TextfieldViewHelper for "required" tag
Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2015-05-22
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Description
There is a major bug in the TextfieldViewHelper (namespace TYPO3\CMS\Fluid\ViewHelpers\Form):
The parameter "required" will be casted as boolean:
/** * Renders the textfield. * * @param bool $required If the field is required or not * @param string $type The field type, e.g. "text", "email", "url" etc. * @return string * @api */ public function render($required = NULL, $type = 'text') {
But in the comparison the parameter is checked if it is not NULL:
if ($required !== NULL) { $this->tag->addAttribute('required', 'required'); }
So it is no matter if you call the function with "required = FALSE" or "required = TRUE", because both is not "NULL".
This should be:
public function render($required = FALSE, $type = 'text') {
if ($required !== FALSE) { $this->tag->addAttribute('required', 'required'); }
Actions